From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] virtio-scsi: Forbid devices with different iothreads sharing a blockdev
Date: Mon, 28 Jan 2019 17:30:28 +0100 [thread overview]
Message-ID: <20190128163028.GJ5756@localhost.localdomain> (raw)
In-Reply-To: <w514l9ssqqv.fsf@maestria.local.igalia.com>
Am 28.01.2019 um 17:15 hat Alberto Garcia geschrieben:
> On Mon 28 Jan 2019 05:01:09 PM CET, Kevin Wolf wrote:
>
> > And actually... if you move the first virtio-blk device to an
> > iothread, then downgrading the others isn't going to save us, because
> > that would still be using the backend from two threads (one
> > successfully enabled iothread, and the main thread).
>
> ...which makes me think that, since patch 1 from this series moves the
> BlockBackend back to the main AioContext on unplug, we could have a
> similar problem if the BDS is being used by other devices. Or am I
> missing something?
Oops. :-)
Maybe we do need to implement the proper solution?
Kevin
next prev parent reply other threads:[~2019-01-28 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:53 [Qemu-devel] [PATCH 0/3] iothread-related fixes for virtio-scsi Alberto Garcia
2019-01-22 15:53 ` [Qemu-devel] [PATCH 1/3] virtio-scsi: Move BlockBackend back to the main AioContext on unplug Alberto Garcia
2019-01-22 15:53 ` [Qemu-devel] [PATCH 2/3] scsi-disk: Acquire the AioContext in scsi_*_realize() Alberto Garcia
2019-01-22 15:53 ` [Qemu-devel] [PATCH 3/3] virtio-scsi: Forbid devices with different iothreads sharing a blockdev Alberto Garcia
2019-01-23 9:46 ` Paolo Bonzini
2019-01-23 15:09 ` Alberto Garcia
2019-01-23 15:47 ` Paolo Bonzini
2019-01-23 16:16 ` Alberto Garcia
2019-01-24 9:12 ` Kevin Wolf
2019-01-28 14:42 ` Alberto Garcia
2019-01-28 14:57 ` Kevin Wolf
2019-01-28 15:46 ` Alberto Garcia
2019-01-28 16:01 ` Kevin Wolf
2019-01-28 16:15 ` Alberto Garcia
2019-01-28 16:30 ` Kevin Wolf [this message]
2019-01-28 15:31 ` [Qemu-devel] [PATCH 0/3] iothread-related fixes for virtio-scsi Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128163028.GJ5756@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).