From: Samuel Thibault <samuel.thibault@gnu.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PULL 00/31] More work towards libslirp
Date: Mon, 28 Jan 2019 20:36:50 +0100 [thread overview]
Message-ID: <20190128193650.wk3axz6jtnk5qwem@function> (raw)
In-Reply-To: <CAFEAcA8zBxFFvBc3taTE3Q=JFdG9VgcCXnZ3=MNE7u8VyvKyrQ@mail.gmail.com>
Peter Maydell, le lun. 28 janv. 2019 15:44:21 +0000, a ecrit:
> Note that g_spawn_async_with_fds() is one of the glib routines
> which we have a version of in glib-compat.h to cope with older
> glib versions -- have you removed the #include of that and
> not provided the equivalent code for slirp?
It seems to be so. Slirp is the only user of this, perhaps I should just
move it there?
> On OpenBSD there are lots of compiler errors, eg:
>
> In file included from slirp/slirp.h:51:0,
> from slirp/arp_table.c:25:
> slirp/ip6.h: In function 'in6_equal':
> slirp/ip6.h:37:5: warning: implicit declaration of function 'memcmp'
Ok, I have folded including string.h inclusion in the corresponding
patch.
Samuel
next prev parent reply other threads:[~2019-01-28 19:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 12:04 [Qemu-devel] [PULL 00/31] More work towards libslirp Samuel Thibault
2019-01-27 12:04 ` [Qemu-devel] [PULL 01/31] slirp: Avoid unaligned 16bit memory access Samuel Thibault
2019-01-27 12:04 ` [Qemu-devel] [PULL 02/31] slirp: Avoid marking naturally packed structs as QEMU_PACKED Samuel Thibault
2019-01-27 12:04 ` [Qemu-devel] [PULL 03/31] slirp: Don't mark struct ipq or struct ipasfrag as packed Samuel Thibault
2019-01-27 12:04 ` [Qemu-devel] [PULL 04/31] slirp: generalize guestfwd with a callback based approach Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 05/31] net/slirp: simplify checking for cmd: prefix Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 06/31] net/slirp: free forwarding rules on cleanup Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 07/31] net/slirp: fix leaks on forwarding rule registration error Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 08/31] slirp: add callbacks for timer Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 09/31] slirp: replace trace functions with DEBUG calls Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 10/31] slirp: replace QEMU_PACKED with SLIRP_PACKED Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 11/31] slirp: replace most qemu socket utilities with slirp own version Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 12/31] slirp: replace qemu_set_nonblock() Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 13/31] slirp: add unregister_poll_fd() callback Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 14/31] slirp: replace qemu_notify_event() with a callback Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 15/31] slirp: move QEMU state saving to a separate unit Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 16/31] slirp: do not include qemu headers in libslirp.h public API header Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 17/31] slirp: improve windows headers inclusion Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 18/31] slirp: add slirp own version of pstrcpy Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 19/31] slirp: remove qemu timer.h dependency Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 20/31] slirp: remove now useless QEMU headers inclusions Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 21/31] slirp: replace net/eth.h inclusion with own defines Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 22/31] slirp: replace qemu qtailq with slirp own copy Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 23/31] slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 24/31] slirp: replace remaining qemu headers dependency Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 25/31] slirp: prefer c99 types over BSD kind Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 26/31] slirp: improve send_packet() callback Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 27/31] slirp: replace global polling with per-instance & notifier Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 28/31] slirp: remove slirp_instances list Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 29/31] slirp: use polling callbacks, drop glib requirement Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 30/31] slirp: pass opaque to all callbacks Samuel Thibault
2019-01-27 12:05 ` [Qemu-devel] [PULL 31/31] slirp: API is extern C Samuel Thibault
2019-01-28 15:44 ` [Qemu-devel] [PULL 00/31] More work towards libslirp Peter Maydell
2019-01-28 19:36 ` Samuel Thibault [this message]
2019-01-31 17:50 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128193650.wk3axz6jtnk5qwem@function \
--to=samuel.thibault@gnu.org \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).