qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com,
	mreitz@redhat.com, eblake@redhat.com, den@openvz.org,
	vsementsov@virtuozzo.com
Subject: Re: [Qemu-devel] [PATCH v9 2/2] qemu-img info: bitmaps extension new test 239
Date: Tue, 29 Jan 2019 10:53:49 +0100	[thread overview]
Message-ID: <20190129095349.GB4467@dhcp-200-176.str.redhat.com> (raw)
In-Reply-To: <1548705688-1027522-3-git-send-email-andrey.shinkevich@virtuozzo.com>

Am 28.01.2019 um 21:01 hat Andrey Shinkevich geschrieben:
> A new test file 239 added to the qemu-iotests set. It checks
> the output format of 'qemu-img info' for bitmaps extension of
> qcow2 specific information.
> 
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>

Can you add human output to the test, too?

Patch 1 changes a few reference outputs that change, including human
output, but they are all without bitmaps. I think we want at least one
test that tests human output with a non-empty list.

Kevin

      reply	other threads:[~2019-01-29  9:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 20:01 [Qemu-devel] [PATCH v9 0/2] qemu-img info lists bitmap directory entries Andrey Shinkevich
2019-01-28 20:01 ` [Qemu-devel] [PATCH v9 1/2] " Andrey Shinkevich
2019-01-28 20:43   ` Eric Blake
2019-01-30 17:55     ` Andrey Shinkevich
2019-01-29  9:52   ` Kevin Wolf
2019-01-29 12:04     ` Andrey Shinkevich
2019-01-29 12:38       ` Kevin Wolf
2019-01-29 12:50         ` Vladimir Sementsov-Ogievskiy
2019-01-29 12:57           ` Vladimir Sementsov-Ogievskiy
2019-01-29 13:17           ` Kevin Wolf
2019-01-29 14:06             ` Vladimir Sementsov-Ogievskiy
2019-01-29 14:23               ` Kevin Wolf
2019-01-29 14:35                 ` Vladimir Sementsov-Ogievskiy
2019-01-29 15:29                   ` Vladimir Sementsov-Ogievskiy
2019-01-29 15:49                     ` Kevin Wolf
2019-01-30 17:55                       ` Andrey Shinkevich
2019-01-28 20:01 ` [Qemu-devel] [PATCH v9 2/2] qemu-img info: bitmaps extension new test 239 Andrey Shinkevich
2019-01-29  9:53   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129095349.GB4467@dhcp-200-176.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).