From: Greg Kurz <groug@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Juan Quintela <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] macOS build error after ddac19f534 (virtio: split virtio 9p bits from virtio-pci)
Date: Tue, 29 Jan 2019 10:04:26 +0100 [thread overview]
Message-ID: <20190129100426.7d61bf55@bahia.lan> (raw)
In-Reply-To: <8b87466e-3e9a-14ae-c827-ac5e61717a87@redhat.com>
On Tue, 29 Jan 2019 08:32:08 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> Hi Zoltan,
>
> On 1/29/19 2:20 AM, BALATON Zoltan wrote:
> > Hello,
> >
> > I'm getting error building on macOS after commit ddac19f534:
> >
> > CC aarch64-softmmu/hw/virtio/virtio-blk-pci.o
> > In file included from qemu/hw/virtio/virtio-9p-pci.c:19:
> > In file included from qemu/hw/9pfs/virtio-9p.h:6:
> > In file included from qemu/hw/9pfs/9p.h:7:
> > qemu/fsdev/file-op-9p.h:19:10: fatal error: 'sys/vfs.h' file not found
> > #include <sys/vfs.h>
> > ^~~~~~~~~~~
> >
> > Am I missing something? (Apart from the include file which is not
> > present on OS X... Maybe this needs the #ifdefs it had before the split?)
>
No, the problem is that virtio-9p-pci should only be compiled on a linux
host.
> It seems commits are not correctly ordered for bisectability :(
>
> If you cherry-pick ecd3b89b054, does it build?
I agree this is likely the problem. A workaround is to pass --disable-virtfs
to configure when bisecting on OS X.
next prev parent reply other threads:[~2019-01-29 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 1:20 [Qemu-devel] macOS build error after ddac19f534 (virtio: split virtio 9p bits from virtio-pci) BALATON Zoltan
2019-01-29 7:32 ` Philippe Mathieu-Daudé
2019-01-29 9:04 ` Greg Kurz [this message]
2019-01-29 10:23 ` BALATON Zoltan
2019-01-29 10:58 ` BALATON Zoltan
2019-01-29 18:16 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129100426.7d61bf55@bahia.lan \
--to=groug@kaod.org \
--cc=balaton@eik.bme.hu \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).