From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: "Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Wei Yang" <richardw.yang@linux.intel.com>,
qemu-trivial@nongnu.org, imammedo@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi
Date: Tue, 29 Jan 2019 10:58:50 -0500 [thread overview]
Message-ID: <20190129105828-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190129153254.r7y2vto4ltxsivpj@master>
On Tue, Jan 29, 2019 at 03:32:54PM +0000, Wei Yang wrote:
> On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote:
> >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote:
> >> On 1/29/19 9:04 AM, Wei Yang wrote:
> >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote:
> >>>> Hi Wei,
> >>>>
> >>>> On 1/29/19 1:08 AM, Wei Yang wrote:
> >>>>> There are several functions/variable which are not used anymore.
> >>>>>
> >>>>> This serials just remove those without functional change.
> >>>>>
> >>>>> Wei Yang (3):
> >>>>> hw/i386/pc.c: remove unused function pc_acpi_init()
> >>>>> hw/acpi: remove unused function acpi_table_add_builtin()
> >>>>> hw/acpi: remove unnecessary variable acpi_table_builtin
> >>>>>
> >>>>> hw/acpi/core.c | 10 +---------
> >>>>> hw/i386/pc.c | 27 ---------------------------
> >>>>> include/hw/acpi/acpi.h | 1 -
> >>>>> include/hw/i386/pc.h | 1 -
> >>>>> 4 files changed, 1 insertion(+), 38 deletions(-)
> >>>>>
> >>>>
> >>>> Please do not post iterated series in reply to previous version, but as
> >>>> new thread:
> >>>> - patches are parsed by scripts
> >>>> - some email clients can tag a thread as "reviewed, skip" and replies to
> >>>> this thread will be masked.
> >>>>
> >>>
> >>> Well, do I need to repost it in a new thread?
> >>
> >> It depends who will take this patchset and his mood :)
> >> Let's wait and see.
> >>
> >
> >No need to repost if they go through the trivial branch.
>
> Thanks :-)
>
> >
> >Thanks,
> >Laurent
Pls repost with all acks etc and I'll pick it up.
> --
> Wei Yang
> Help you, Help me
next prev parent reply other threads:[~2019-01-29 15:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 6:01 [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-25 6:01 ` [Qemu-devel] [PATCH 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
2019-01-25 6:01 ` [Qemu-devel] [PATCH 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-28 13:32 ` [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Igor Mammedov
2019-01-29 0:01 ` Wei Yang
2019-01-29 0:08 ` [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-29 0:08 ` [Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-29 8:25 ` Philippe Mathieu-Daudé
2019-01-29 0:08 ` [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
2019-01-29 8:27 ` Philippe Mathieu-Daudé
2019-01-29 0:08 ` [Qemu-devel] [PATCH v2 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-29 8:30 ` Philippe Mathieu-Daudé
2019-01-29 6:56 ` [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi Philippe Mathieu-Daudé
2019-01-29 8:04 ` Wei Yang
2019-01-29 8:23 ` Philippe Mathieu-Daudé
2019-01-29 8:43 ` Laurent Vivier
2019-01-29 15:32 ` Wei Yang
2019-01-29 15:58 ` Michael S. Tsirkin [this message]
2019-01-29 23:58 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129105828-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=imammedo@redhat.com \
--cc=laurent@vivier.eu \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.weiyang@gmail.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).