[Qemu-devel] [RFC PATCH] block: local qiov helper

[Qemu-devel] [RFC PATCH] block: local qiov helper

[Vladimir Sementsov-Ogievskiy]

Hi all.

What about such a simple helper for a very often patter around
qemu_iovec_init_external ?

If we like it, I'll update other callers of qemu_iovec_init_external.

Possible interface change would be
LOCAL_QIOV(lc, buf, len);
instead of 
LocalQiov lc = LOCAL_QIOV(lc, buf, len);

or, may be, someone has a better idea?

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 include/qemu/iov.h | 19 +++++++++++++++++++
 block/io.c         |  9 ++-------
 2 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/include/qemu/iov.h b/include/qemu/iov.h
index 5f433c7768..e0963d8ebe 100644
--- a/include/qemu/iov.h
+++ b/include/qemu/iov.h
@@ -137,6 +137,25 @@ typedef struct QEMUIOVector {
     size_t size;
 } QEMUIOVector;
 
+typedef struct LocalQiov {
+    QEMUIOVector qiov;
+    struct iovec iov;
+} LocalQiov;
+
+#define LOCAL_QIOV(self, buf, len)    \
+{                                     \
+    .qiov = {                         \
+        .iov = &self.iov,             \
+        .size = len,                  \
+        .niov = 1,                    \
+        .nalloc = -1                  \
+    },                                \
+    .iov = {                          \
+        .iov_base = (void *)(buf),    \
+        .iov_len = len                \
+    }                                 \
+}
+
 void qemu_iovec_init(QEMUIOVector *qiov, int alloc_hint);
 void qemu_iovec_init_external(QEMUIOVector *qiov, struct iovec *iov, int niov);
 void qemu_iovec_add(QEMUIOVector *qiov, void *base, size_t len);
diff --git a/block/io.c b/block/io.c
index bd9d688f8b..c7d7b199c1 100644
--- a/block/io.c
+++ b/block/io.c
@@ -949,18 +949,13 @@ int bdrv_preadv(BdrvChild *child, int64_t offset, QEMUIOVector *qiov)
 
 int bdrv_pread(BdrvChild *child, int64_t offset, void *buf, int bytes)
 {
-    QEMUIOVector qiov;
-    struct iovec iov = {
-        .iov_base = (void *)buf,
-        .iov_len = bytes,
-    };
+    LocalQiov lq = LOCAL_QIOV(lq, buf, bytes);
 
     if (bytes < 0) {
         return -EINVAL;
     }
 
-    qemu_iovec_init_external(&qiov, &iov, 1);
-    return bdrv_preadv(child, offset, &qiov);
+    return bdrv_preadv(child, offset, &lq.qiov);
 }
 
 int bdrv_pwritev(BdrvChild *child, int64_t offset, QEMUIOVector *qiov)
-- 
2.18.0

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1920 bytes --]

On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all.
> 
> What about such a simple helper for a very often patter around
> qemu_iovec_init_external ?

Sounds good, qemu_iovec_init() has 55 references vs
qemu_iovec_init_external() with 51.  It's worth making
qemu_iovec_init_external() nicer to use.

> If we like it, I'll update other callers of qemu_iovec_init_external.
> 
> Possible interface change would be
> LOCAL_QIOV(lc, buf, len);
> instead of 
> LocalQiov lc = LOCAL_QIOV(lc, buf, len);
> 
> or, may be, someone has a better idea?

Bike-shedding territory, but I prefer LocalQiov lc = LOCAL_QIOV(lc, buf,
len) because it reveals the type.  This makes the code easier to read
than just LOCAL_QIOV(lc, buf, len) by itself - the reader is forced to
look up the macro definition to figure out what magic happens.

> diff --git a/block/io.c b/block/io.c
> index bd9d688f8b..c7d7b199c1 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -949,18 +949,13 @@ int bdrv_preadv(BdrvChild *child, int64_t offset, QEMUIOVector *qiov)
>  
>  int bdrv_pread(BdrvChild *child, int64_t offset, void *buf, int bytes)
>  {
> -    QEMUIOVector qiov;
> -    struct iovec iov = {
> -        .iov_base = (void *)buf,
> -        .iov_len = bytes,
> -    };
> +    LocalQiov lq = LOCAL_QIOV(lq, buf, bytes);
>  
>      if (bytes < 0) {
>          return -EINVAL;
>      }
>  
> -    qemu_iovec_init_external(&qiov, &iov, 1);
> -    return bdrv_preadv(child, offset, &qiov);
> +    return bdrv_preadv(child, offset, &lq.qiov);

I think it's unfortunate that LocalQiov is necessary since the caller
only needs the qiov.  Can we afford to embed the struct iovec into
QEMUIOVector?

That way callers don't need a separate LocalQiov type:

  QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);
  ...
  return bdrv_preadv(child, offset, &qiov);

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

[Vladimir Sementsov-Ogievskiy]

29.01.2019 6:31, Stefan Hajnoczi wrote:
> On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all.
>>
>> What about such a simple helper for a very often patter around
>> qemu_iovec_init_external ?
> 
> Sounds good, qemu_iovec_init() has 55 references vs
> qemu_iovec_init_external() with 51.  It's worth making
> qemu_iovec_init_external() nicer to use.
> 
>> If we like it, I'll update other callers of qemu_iovec_init_external.
>>
>> Possible interface change would be
>> LOCAL_QIOV(lc, buf, len);
>> instead of
>> LocalQiov lc = LOCAL_QIOV(lc, buf, len);
>>
>> or, may be, someone has a better idea?
> 
> Bike-shedding territory, but I prefer LocalQiov lc = LOCAL_QIOV(lc, buf,
> len) because it reveals the type.  This makes the code easier to read
> than just LOCAL_QIOV(lc, buf, len) by itself - the reader is forced to
> look up the macro definition to figure out what magic happens.
> 
>> diff --git a/block/io.c b/block/io.c
>> index bd9d688f8b..c7d7b199c1 100644
>> --- a/block/io.c
>> +++ b/block/io.c
>> @@ -949,18 +949,13 @@ int bdrv_preadv(BdrvChild *child, int64_t offset, QEMUIOVector *qiov)
>>   
>>   int bdrv_pread(BdrvChild *child, int64_t offset, void *buf, int bytes)
>>   {
>> -    QEMUIOVector qiov;
>> -    struct iovec iov = {
>> -        .iov_base = (void *)buf,
>> -        .iov_len = bytes,
>> -    };
>> +    LocalQiov lq = LOCAL_QIOV(lq, buf, bytes);
>>   
>>       if (bytes < 0) {
>>           return -EINVAL;
>>       }
>>   
>> -    qemu_iovec_init_external(&qiov, &iov, 1);
>> -    return bdrv_preadv(child, offset, &qiov);
>> +    return bdrv_preadv(child, offset, &lq.qiov);
> 
> I think it's unfortunate that LocalQiov is necessary since the caller
> only needs the qiov.  Can we afford to embed the struct iovec into
> QEMUIOVector?
> 
> That way callers don't need a separate LocalQiov type:
> 
>    QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);
>    ...
>    return bdrv_preadv(child, offset, &qiov);
> 


Hmm. In this case we definitely will have tiny extra memory usage, but we gain beautiful
readability.

So, like this:

diff --git a/include/qemu/iov.h b/include/qemu/iov.h
index 5f433c7768..53de1b38bb 100644
--- a/include/qemu/iov.h
+++ b/include/qemu/iov.h
@@ -134,9 +134,31 @@ typedef struct QEMUIOVector {
      struct iovec *iov;
      int niov;
      int nalloc;
-    size_t size;
+    union {
+        struct {
+            void *__unused_iov_base;
+            size_t size;
+        };
+        struct iovec local_iov;
+    };
  } QEMUIOVector;

+G_STATIC_ASSERT(offsetof(QEMUIOVector, size) ==
+                offsetof(QEMUIOVector, local_iov.iov_len));
+G_STATIC_ASSERT(sizeof(((QEMUIOVector *)NULL)->size) ==
+                sizeof(((QEMUIOVector *)NULL)->local_iov.iov_len));
+
+#define QEMU_IOVEC_INIT_BUF(self, buf, len) \
+{                                           \
+    .iov = &self.local_iov,                 \
+    .niov = 1,                              \
+    .nalloc = -1,                           \
+    .local_iov = {                          \
+        .iov_base = (void *)(buf),          \
+        .iov_len = len                      \
+    }                                       \
+}
+
  void qemu_iovec_init(QEMUIOVector *qiov, int alloc_hint);
  void qemu_iovec_init_external(QEMUIOVector *qiov, struct iovec *iov, int niov);
  void qemu_iovec_add(QEMUIOVector *qiov, void *base, size_t len);
diff --git a/block/io.c b/block/io.c
index bd9d688f8b..39a1a848af 100644
--- a/block/io.c
+++ b/block/io.c
@@ -949,17 +949,12 @@ int bdrv_preadv(BdrvChild *child, int64_t offset, QEMUIOVector *qiov)

  int bdrv_pread(BdrvChild *child, int64_t offset, void *buf, int bytes)
  {
-    QEMUIOVector qiov;
-    struct iovec iov = {
-        .iov_base = (void *)buf,
-        .iov_len = bytes,
-    };
+    QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);

      if (bytes < 0) {
          return -EINVAL;
      }

-    qemu_iovec_init_external(&qiov, &iov, 1);
      return bdrv_preadv(child, offset, &qiov);
  }



Ok?


It's also possible to unite nalloc and local_iov.iov_base, to save 4 bytes, and we'll have to add

  void qemu_iovec_add(QEMUIOVector *qiov, void *base, size_t len)
  {
-    assert(qiov->nalloc != -1);
+    assert(qiov->iov != &qiov->local_iov && qiov->nalloc != -1);

But I think it's not worth it.

-- 
Best regards,
Vladimir

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

[Stefan Hajnoczi]

On Tue, Jan 29, 2019 at 6:24 PM Vladimir Sementsov-Ogievskiy
<vsementsov@virtuozzo.com> wrote:
> 29.01.2019 6:31, Stefan Hajnoczi wrote:
> > On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hmm. In this case we definitely will have tiny extra memory usage, but we gain beautiful
> readability.
>
> So, like this:
>
> diff --git a/include/qemu/iov.h b/include/qemu/iov.h
> index 5f433c7768..53de1b38bb 100644
> --- a/include/qemu/iov.h
> +++ b/include/qemu/iov.h
> @@ -134,9 +134,31 @@ typedef struct QEMUIOVector {
>       struct iovec *iov;
>       int niov;
>       int nalloc;
> -    size_t size;
> +    union {
> +        struct {
> +            void *__unused_iov_base;

This could be struct iovec *iov for nalloc > 0 users.  Must resist hackiness! :)

> +            size_t size;
> +        };
> +        struct iovec local_iov;
> +    };
>   } QEMUIOVector;

That's clever and not too hacky.  Please include a comment so the
intent is clear:

  /* Save space by reusing the embedded iovec's size field as the
total size field.  Users with external iovecs don't use the embedded
iovec so this is safe. */

Stefan

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

[Vladimir Sementsov-Ogievskiy]

29.01.2019 13:32, Stefan Hajnoczi wrote:
> On Tue, Jan 29, 2019 at 6:24 PM Vladimir Sementsov-Ogievskiy
> <vsementsov@virtuozzo.com> wrote:
>> 29.01.2019 6:31, Stefan Hajnoczi wrote:
>>> On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> Hmm. In this case we definitely will have tiny extra memory usage, but we gain beautiful
>> readability.
>>
>> So, like this:
>>
>> diff --git a/include/qemu/iov.h b/include/qemu/iov.h
>> index 5f433c7768..53de1b38bb 100644
>> --- a/include/qemu/iov.h
>> +++ b/include/qemu/iov.h
>> @@ -134,9 +134,31 @@ typedef struct QEMUIOVector {
>>        struct iovec *iov;
>>        int niov;
>>        int nalloc;
>> -    size_t size;
>> +    union {
>> +        struct {
>> +            void *__unused_iov_base;
> 
> This could be struct iovec *iov for nalloc > 0 users.  Must resist hackiness! :)

can't be iov, gcc complains:
include/qemu/iov.h:139:27: error: duplicate member ‘iov’
              struct iovec *iov;

> 
>> +            size_t size;
>> +        };
>> +        struct iovec local_iov;
>> +    };
>>    } QEMUIOVector;
> 
> That's clever and not too hacky.  Please include a comment so the
> intent is clear:
> 
>    /* Save space by reusing the embedded iovec's size field as the
> total size field.  Users with external iovecs don't use the embedded
> iovec so this is safe. */
> 
> Stefan
> 


-- 
Best regards,
Vladimir

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

[Kevin Wolf]

Am 29.01.2019 um 12:18 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 29.01.2019 13:32, Stefan Hajnoczi wrote:
> > On Tue, Jan 29, 2019 at 6:24 PM Vladimir Sementsov-Ogievskiy
> > <vsementsov@virtuozzo.com> wrote:
> >> 29.01.2019 6:31, Stefan Hajnoczi wrote:
> >>> On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> >> Hmm. In this case we definitely will have tiny extra memory usage, but we gain beautiful
> >> readability.
> >>
> >> So, like this:
> >>
> >> diff --git a/include/qemu/iov.h b/include/qemu/iov.h
> >> index 5f433c7768..53de1b38bb 100644
> >> --- a/include/qemu/iov.h
> >> +++ b/include/qemu/iov.h
> >> @@ -134,9 +134,31 @@ typedef struct QEMUIOVector {
> >>        struct iovec *iov;
> >>        int niov;
> >>        int nalloc;
> >> -    size_t size;
> >> +    union {
> >> +        struct {
> >> +            void *__unused_iov_base;
> > 
> > This could be struct iovec *iov for nalloc > 0 users.  Must resist hackiness! :)
> 
> can't be iov, gcc complains:
> include/qemu/iov.h:139:27: error: duplicate member ‘iov’
>               struct iovec *iov;

I think Stefan meant moving the existing iov here. But then we would
have to make sure that it's never used for local qiovs, which would
probably involve touching a lot more code.

Your original suggestion to put nalloc there looks a bit more practical
if we want to save those bytes.

Kevin

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

On Tue, Jan 29, 2019 at 01:34:48PM +0100, Kevin Wolf wrote:
> Am 29.01.2019 um 12:18 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > 29.01.2019 13:32, Stefan Hajnoczi wrote:
> > > On Tue, Jan 29, 2019 at 6:24 PM Vladimir Sementsov-Ogievskiy
> > > <vsementsov@virtuozzo.com> wrote:
> > >> 29.01.2019 6:31, Stefan Hajnoczi wrote:
> > >>> On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > >> Hmm. In this case we definitely will have tiny extra memory usage, but we gain beautiful
> > >> readability.
> > >>
> > >> So, like this:
> > >>
> > >> diff --git a/include/qemu/iov.h b/include/qemu/iov.h
> > >> index 5f433c7768..53de1b38bb 100644
> > >> --- a/include/qemu/iov.h
> > >> +++ b/include/qemu/iov.h
> > >> @@ -134,9 +134,31 @@ typedef struct QEMUIOVector {
> > >>        struct iovec *iov;
> > >>        int niov;
> > >>        int nalloc;
> > >> -    size_t size;
> > >> +    union {
> > >> +        struct {
> > >> +            void *__unused_iov_base;
> > > 
> > > This could be struct iovec *iov for nalloc > 0 users.  Must resist hackiness! :)
> > 
> > can't be iov, gcc complains:
> > include/qemu/iov.h:139:27: error: duplicate member ‘iov’
> >               struct iovec *iov;
> 
> I think Stefan meant moving the existing iov here. But then we would
> have to make sure that it's never used for local qiovs, which would
> probably involve touching a lot more code.
> 
> Your original suggestion to put nalloc there looks a bit more practical
> if we want to save those bytes.

Sounds good.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [RFC PATCH] block: local qiov helper

[no-reply]

Patchew URL: https://patchew.org/QEMU/20190125164601.130556-1-vsementsov@virtuozzo.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===

Configure options:
--enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/tmp/qemu-test/install --python=/usr/bin/python3 --cross-prefix=x86_64-w64-mingw32- --enable-trace-backends=simple --enable-gnutls --enable-nettle --enable-curl --enable-vnc --enable-bzip2 --enable-guest-agent --with-sdlabi=2.0

ERROR: "x86_64-w64-mingw32-gcc" either does not exist or does not work

# QEMU configure log Sun Feb  3 05:54:12 UTC 2019
# Configured with: '/tmp/qemu-test/src/configure' '--enable-werror' '--target-list=x86_64-softmmu,aarch64-softmmu' '--prefix=/tmp/qemu-test/install' '--python=/usr/bin/python3' '--cross-prefix=x86_64-w64-mingw32-' '--enable-trace-backends=simple' '--enable-gnutls' '--enable-nettle' '--enable-curl' '--enable-vnc' '--enable-bzip2' '--enable-guest-agent' '--with-sdlabi=2.0'
---
funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 636 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 638 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 640 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 642 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 644 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 646 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 648 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 650 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 652 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 654 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 688 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 690 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 696 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 702 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 708 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 710 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 716 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 722 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object check_define main
lines: 92 122 619 724 0
x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied

funcs: do_compiler do_cc compile_object main
lines: 92 122 1820 0
x86_64-w64-mingw32-gcc -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
ccache: error: Failed to create temporary file for /var/tmp/ccache/tmp/qemu-conf.stdout: Permission denied
Failed to run 'configure'
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 563, in <module>


The full log is available at
http://patchew.org/logs/20190125164601.130556-1-vsementsov@virtuozzo.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com