From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goddM-0001Fx-T9 for qemu-devel@nongnu.org; Tue, 29 Jan 2019 19:21:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goddD-00042T-Nw for qemu-devel@nongnu.org; Tue, 29 Jan 2019 19:21:34 -0500 Date: Wed, 30 Jan 2019 07:58:40 +0800 From: Wei Yang Message-ID: <20190129235840.GA15790@richard> Reply-To: Wei Yang References: <20190125060157.29935-1-richardw.yang@linux.intel.com> <20190129000820.31190-1-richardw.yang@linux.intel.com> <20190129080455.GA10084@richard> <91c53c72-8e9c-f68d-1dc8-f6320ed3dfc0@redhat.com> <20190129153254.r7y2vto4ltxsivpj@master> <20190129105828-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190129105828-mutt-send-email-mst@kernel.org> Subject: Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Wei Yang , Laurent Vivier , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Wei Yang , qemu-trivial@nongnu.org, imammedo@redhat.com, qemu-devel@nongnu.org On Tue, Jan 29, 2019 at 10:58:50AM -0500, Michael S. Tsirkin wrote: >On Tue, Jan 29, 2019 at 03:32:54PM +0000, Wei Yang wrote: >> On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: >> >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: >> >> On 1/29/19 9:04 AM, Wei Yang wrote: >> >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >> >>>> Hi Wei, >> >>>> >> >>>> On 1/29/19 1:08 AM, Wei Yang wrote: >> >>>>> There are several functions/variable which are not used anymore. >> >>>>> >> >>>>> This serials just remove those without functional change. >> >>>>> >> >>>>> Wei Yang (3): >> >>>>> hw/i386/pc.c: remove unused function pc_acpi_init() >> >>>>> hw/acpi: remove unused function acpi_table_add_builtin() >> >>>>> hw/acpi: remove unnecessary variable acpi_table_builtin >> >>>>> >> >>>>> hw/acpi/core.c | 10 +--------- >> >>>>> hw/i386/pc.c | 27 --------------------------- >> >>>>> include/hw/acpi/acpi.h | 1 - >> >>>>> include/hw/i386/pc.h | 1 - >> >>>>> 4 files changed, 1 insertion(+), 38 deletions(-) >> >>>>> >> >>>> >> >>>> Please do not post iterated series in reply to previous version, but as >> >>>> new thread: >> >>>> - patches are parsed by scripts >> >>>> - some email clients can tag a thread as "reviewed, skip" and replies to >> >>>> this thread will be masked. >> >>>> >> >>> >> >>> Well, do I need to repost it in a new thread? >> >> >> >> It depends who will take this patchset and his mood :) >> >> Let's wait and see. >> >> >> > >> >No need to repost if they go through the trivial branch. >> >> Thanks :-) >> >> > >> >Thanks, >> >Laurent > >Pls repost with all acks etc and I'll pick it up. > Got it. >> -- >> Wei Yang >> Help you, Help me -- Wei Yang Help you, Help me