From: Cornelia Huck <cohuck@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, david@redhat.com, pasic@linux.ibm.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v4] s390x: remove direct reference to mem_path global from s390x code
Date: Wed, 30 Jan 2019 10:41:55 +0100 [thread overview]
Message-ID: <20190130104155.08cc0ac9.cohuck@redhat.com> (raw)
In-Reply-To: <1548834906-133241-1-git-send-email-imammedo@redhat.com>
On Wed, 30 Jan 2019 08:55:06 +0100
Igor Mammedov <imammedo@redhat.com> wrote:
> I plan to deprecate -mem-path option and replace it with memory-backend,
> for that it's necessary to get rid of mem_path global variable.
> Do it for s390x case, replacing it with alternative way to enable
> 1Mb hugepages capability.
>
> Todo that replace qemu_mempath_getpagesize() with qemu_getrampagesize()
> which also checks for -mem-path provided RAM.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v4:
> * fix typos in commit message
> * add include "exec/ram_addr.h" to make sure it compiles on ppc host
> v2:
> * s/qemu_mempath_getpagesize/qemu_getrampagesiz/ and drop the rest of changes
> David Hildenbrand <david@redhat.com>
Something odd happened here -- I presume you did not want to drop
David's R-b?
[I can re-add while applying, no need to resend.]
> ---
> target/s390x/kvm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2019-01-30 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 7:55 [Qemu-devel] [PATCH v4] s390x: remove direct reference to mem_path global from s390x code Igor Mammedov
2019-01-30 9:41 ` Cornelia Huck [this message]
2019-01-30 11:18 ` David Hildenbrand
2019-01-30 12:21 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130104155.08cc0ac9.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).