From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v2 09/10] iotests: Let 045 be run concurrently
Date: Wed, 30 Jan 2019 16:24:33 +0100 [thread overview]
Message-ID: <20190130152434.17283-10-mreitz@redhat.com> (raw)
In-Reply-To: <20190130152434.17283-1-mreitz@redhat.com>
Adding a telnet monitor for no real purpose on a fixed port is not so
great. Just use a null monitor instead.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
scripts/qemu.py | 5 ++---
tests/qemu-iotests/045 | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 0a5e02eb56..e642a55816 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -136,10 +136,9 @@ class QEMUMachine(object):
return False
# This can be used to add an unused monitor instance.
- def add_monitor_telnet(self, ip, port):
- args = 'tcp:%s:%d,server,nowait,telnet' % (ip, port)
+ def add_monitor_null(self):
self._args.append('-monitor')
- self._args.append(args)
+ self._args.append('null')
def add_fd(self, fd, fdset, opaque, opts=''):
"""
diff --git a/tests/qemu-iotests/045 b/tests/qemu-iotests/045
index 55a5d31ca8..d5484a0ee1 100755
--- a/tests/qemu-iotests/045
+++ b/tests/qemu-iotests/045
@@ -132,7 +132,7 @@ class TestSCMFd(iotests.QMPTestCase):
qemu_img('create', '-f', iotests.imgfmt, image0, '128K')
# Add an unused monitor, to verify it works fine when two monitor
# instances present
- self.vm.add_monitor_telnet("0",4445)
+ self.vm.add_monitor_null()
self.vm.launch()
def tearDown(self):
--
2.20.1
next prev parent reply other threads:[~2019-01-30 15:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 15:24 [Qemu-devel] [PATCH v2 00/10] iotests: Fix some issues Max Reitz
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 01/10] iotests: Re-add filename filters Max Reitz
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 02/10] iotests: Fix 237 for Python 2.x Max Reitz
2019-01-30 16:35 ` Philippe Mathieu-Daudé
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 03/10] iotests: Remove superfluous rm from 232 Max Reitz
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 04/10] iotests: Fix 232 for LUKS Max Reitz
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 05/10] iotests: Fix 207 to use QMP filters for qmp_log Max Reitz
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 06/10] iotests.py: Add is_str() Max Reitz
2019-01-30 20:10 ` John Snow
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 07/10] iotests.py: Filter filename in any string value Max Reitz
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 08/10] iotests: Filter SSH paths Max Reitz
2019-01-30 15:24 ` Max Reitz [this message]
2019-01-30 20:11 ` [Qemu-devel] [PATCH v2 09/10] iotests: Let 045 be run concurrently John Snow
2019-01-30 15:24 ` [Qemu-devel] [PATCH v2 10/10] iotests.py: s/_/-/g on keys in qmp_log() Max Reitz
2019-01-30 23:09 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130152434.17283-10-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).