From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Max Reitz <mreitz@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 11/20] iotests: add iotest 236 for testing bitmap merge
Date: Wed, 30 Jan 2019 18:27:34 +0100 [thread overview]
Message-ID: <20190130172734.GB892@localhost.localdomain> (raw)
In-Reply-To: <20190114162605.5330-12-eblake@redhat.com>
Am 14.01.2019 um 17:25 hat Eric Blake geschrieben:
> From: John Snow <jsnow@redhat.com>
>
> New interface, new smoke test.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Message-Id: <20181221093529.23855-12-jsnow@redhat.com>
> [eblake: fix last-minute change to echo text]
> Signed-off-by: Eric Blake <eblake@redhat.com>
This test fails for me (with Python 3) because I get a different dict
order.
Probably related to the OrderedDict that qmp_log() uses, so log() uses
sort_keys=False and the unordered dicts that are contained in the outer
OrderedDict stay unordered.
Kevin
next prev parent reply other threads:[~2019-01-30 17:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 16:25 [Qemu-devel] [PULL 00/20] NBD patches through 2019-01-14 Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 01/20] blockdev: abort transactions in reverse order Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 02/20] block/dirty-bitmap: remove assertion from restore Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 03/20] blockdev: n-ary bitmap merge Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 04/20] block: remove 'x' prefix from experimental bitmap APIs Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 05/20] iotests.py: don't abort if IMGKEYSECRET is undefined Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 06/20] iotests: add filter_generated_node_ids Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 07/20] iotests: add qmp recursive sorting function Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 08/20] iotests: remove default filters from qmp_log Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 09/20] iotests: change qmp_log filters to expect QMP objects only Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 10/20] iotests: implement pretty-print for log and qmp_log Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 11/20] iotests: add iotest 236 for testing bitmap merge Eric Blake
2019-01-30 17:27 ` Kevin Wolf [this message]
2019-01-30 17:58 ` John Snow
2019-01-31 2:03 ` John Snow
2019-01-31 8:55 ` Kevin Wolf
2019-02-01 20:16 ` John Snow
2019-01-14 16:25 ` [Qemu-devel] [PULL 12/20] qemu-nbd: Rename 'exp' variable clashing with math::exp() symbol Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 13/20] nbd: Add some error case testing to iotests 223 Eric Blake
2019-01-14 16:25 ` [Qemu-devel] [PULL 14/20] nbd: Forbid nbd-server-stop when server is not running Eric Blake
2019-01-14 16:26 ` [Qemu-devel] [PULL 15/20] nbd: Only require disabled bitmap for read-only exports Eric Blake
2019-01-14 16:26 ` [Qemu-devel] [PULL 16/20] nbd: Merge nbd_export_set_name into nbd_export_new Eric Blake
2019-01-14 16:26 ` [Qemu-devel] [PULL 17/20] nbd: Allow bitmap export during QMP nbd-server-add Eric Blake
2019-01-14 16:26 ` [Qemu-devel] [PULL 18/20] nbd: Remove x-nbd-server-add-bitmap Eric Blake
2019-01-14 16:26 ` [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new Eric Blake
2019-02-07 18:40 ` Peter Maydell
2019-02-07 19:00 ` Eric Blake
2019-02-07 19:05 ` Peter Maydell
2019-02-07 19:17 ` Eric Blake
2019-01-14 16:26 ` [Qemu-devel] [PULL 20/20] qemu-nbd: Add --bitmap=NAME option Eric Blake
2019-01-15 17:23 ` [Qemu-devel] [PULL 00/20] NBD patches through 2019-01-14 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130172734.GB892@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).