[Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check

[Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check

[Mathew Maidment]

Hi,

This is a patch that fixes a condition within disas_uncond_b_reg() related to
BRAA and BLRAA that would always result in the unallocated encoding path being
taken.

Hopefully everything is in order. This is only my second patch, so if anything
is wrong, that's my bad.

Thanks in advance for reviewing =)

Mathew Maidment (1):
  target/arm: Amend erroneous BRAA/BLRAA opcode check

 target/arm/translate-a64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.2 (Apple Git-113)

[Qemu-devel] [PATCH 1/1] target/arm: Amend erroneous BRAA/BLRAA opcode check

[Mathew Maidment]

Amends a small logical mistake that would always result in the branch to
do_unallocated being taken.

Signed-off-by: Mathew Maidment <mathew1800@gmail.com>
---
 target/arm/translate-a64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 4d28a27c3b..350deae32b 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -2036,7 +2036,7 @@ static void disas_uncond_b_reg(DisasContext *s, uint32_t insn)
         if (!dc_isar_feature(aa64_pauth, s)) {
             goto do_unallocated;
         }
-        if (op3 != 2 || op3 != 3) {
+        if (op3 != 2 && op3 != 3) {
             goto do_unallocated;
         }
         if (s->pauth_active) {
-- 
2.17.2 (Apple Git-113)

Re: [Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check

[Peter Maydell]

On Wed, 30 Jan 2019 at 20:22, Mathew Maidment <mathew1800@gmail.com> wrote:
> This is a patch that fixes a condition within disas_uncond_b_reg() related to
> BRAA and BLRAA that would always result in the unallocated encoding path being
> taken.
>
> Hopefully everything is in order. This is only my second patch, so if anything
> is wrong, that's my bad.
>
> Thanks in advance for reviewing =)

Hi -- thanks for this patch. I think this bug is already
covered by this patch that went onto the mailing list last week:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06728.html
-- you might like to test that series.


thanks
-- PMM