* [Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check
@ 2019-01-30 20:22 Mathew Maidment
2019-01-30 20:22 ` [Qemu-devel] [PATCH 1/1] " Mathew Maidment
2019-01-31 13:18 ` [Qemu-devel] [PATCH 0/1] " Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Mathew Maidment @ 2019-01-30 20:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell
Hi,
This is a patch that fixes a condition within disas_uncond_b_reg() related to
BRAA and BLRAA that would always result in the unallocated encoding path being
taken.
Hopefully everything is in order. This is only my second patch, so if anything
is wrong, that's my bad.
Thanks in advance for reviewing =)
Mathew Maidment (1):
target/arm: Amend erroneous BRAA/BLRAA opcode check
target/arm/translate-a64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.2 (Apple Git-113)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH 1/1] target/arm: Amend erroneous BRAA/BLRAA opcode check
2019-01-30 20:22 [Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check Mathew Maidment
@ 2019-01-30 20:22 ` Mathew Maidment
2019-01-31 13:18 ` [Qemu-devel] [PATCH 0/1] " Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Mathew Maidment @ 2019-01-30 20:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell
Amends a small logical mistake that would always result in the branch to
do_unallocated being taken.
Signed-off-by: Mathew Maidment <mathew1800@gmail.com>
---
target/arm/translate-a64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 4d28a27c3b..350deae32b 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -2036,7 +2036,7 @@ static void disas_uncond_b_reg(DisasContext *s, uint32_t insn)
if (!dc_isar_feature(aa64_pauth, s)) {
goto do_unallocated;
}
- if (op3 != 2 || op3 != 3) {
+ if (op3 != 2 && op3 != 3) {
goto do_unallocated;
}
if (s->pauth_active) {
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check
2019-01-30 20:22 [Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check Mathew Maidment
2019-01-30 20:22 ` [Qemu-devel] [PATCH 1/1] " Mathew Maidment
@ 2019-01-31 13:18 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2019-01-31 13:18 UTC (permalink / raw)
To: Mathew Maidment; +Cc: QEMU Developers
On Wed, 30 Jan 2019 at 20:22, Mathew Maidment <mathew1800@gmail.com> wrote:
> This is a patch that fixes a condition within disas_uncond_b_reg() related to
> BRAA and BLRAA that would always result in the unallocated encoding path being
> taken.
>
> Hopefully everything is in order. This is only my second patch, so if anything
> is wrong, that's my bad.
>
> Thanks in advance for reviewing =)
Hi -- thanks for this patch. I think this bug is already
covered by this patch that went onto the mailing list last week:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06728.html
-- you might like to test that series.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-31 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-30 20:22 [Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check Mathew Maidment
2019-01-30 20:22 ` [Qemu-devel] [PATCH 1/1] " Mathew Maidment
2019-01-31 13:18 ` [Qemu-devel] [PATCH 0/1] " Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).