From: Mathew Maidment <mathew1800@gmail.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH 1/1] target/arm: Amend erroneous BRAA/BLRAA opcode check
Date: Wed, 30 Jan 2019 15:22:43 -0500 [thread overview]
Message-ID: <20190130202243.79545-2-mathew1800@gmail.com> (raw)
In-Reply-To: <20190130202243.79545-1-mathew1800@gmail.com>
Amends a small logical mistake that would always result in the branch to
do_unallocated being taken.
Signed-off-by: Mathew Maidment <mathew1800@gmail.com>
---
target/arm/translate-a64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 4d28a27c3b..350deae32b 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -2036,7 +2036,7 @@ static void disas_uncond_b_reg(DisasContext *s, uint32_t insn)
if (!dc_isar_feature(aa64_pauth, s)) {
goto do_unallocated;
}
- if (op3 != 2 || op3 != 3) {
+ if (op3 != 2 && op3 != 3) {
goto do_unallocated;
}
if (s->pauth_active) {
--
2.17.2 (Apple Git-113)
next prev parent reply other threads:[~2019-01-30 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 20:22 [Qemu-devel] [PATCH 0/1] target/arm: Amend erroneous BRAA/BLRAA opcode check Mathew Maidment
2019-01-30 20:22 ` Mathew Maidment [this message]
2019-01-31 13:18 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130202243.79545-2-mathew1800@gmail.com \
--to=mathew1800@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).