qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Adam Baxter <voltagex@voltagex.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] NSIS - including DLL dependencies for Windows
Date: Thu, 31 Jan 2019 10:49:11 +0000	[thread overview]
Message-ID: <20190131104911.GF19982@redhat.com> (raw)
In-Reply-To: <CAChFQ9RNaHyROB47QeLwc6cLCCnFx4SmXKV7rbs1MYjk7S0sbw@mail.gmail.com>

On Thu, Jan 31, 2019 at 02:45:13PM +1100, Adam Baxter wrote:
> Hi,
> How do I gather and include the required DLLs (SDL, zlib etc) in the NSIS
> installer? (and also in a standalone build to be zipped up, but that's less
> important)
> 
> I noticed the wiki doesn't really mention bundling dependencies anywhere.
> 
> The official unofficial windows builds are documented at
> https://qemu.weilnetz.de/FAQ but this doesn't cover building the actual
> installer.

Yeah, this is a pretty major ommision in QEMU's build rules for the NSIS
installer making it pretty much useless as is. We really need to expand
it so that it can resolve the dlls that qemu .exe's need, locate them
on the host and bundle them into the installer automatically.

It seems we can get a list of deps for an .exe using 

$ winedump  -j import /path/to/binary.exe  | grep offset | grep dll | awk '{print $3}'

We would need to run that for each .exe we're bundling. I think we might
need to also then run that recursively for each .dll to get the transitive
set of required dlls.

Even this is not entirely satisfactory though, as it is blindly assuming
that the only thing we need in the QEMU installer is the dlls themselves.
GTK at least has other resources used at runtime besides the dll that
should be bundled.

This kind of problem is why the GNOME project created the msitools project
for creating .msi installers, to relpace nsis. With msitools there is a
metadata file for each package listing all the files that need it needs
to have bundled into an installer:

  https://gitlab.gnome.org/GNOME/msitools/tree/master/data/wixl

This is not without its own downsides though. It bundles all the .wxi
files itself, with their content based on current mingw packages present
in the most recent Fedora release. This means it won't work on any other
distro :-(

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2019-01-31 10:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31  3:45 [Qemu-devel] NSIS - including DLL dependencies for Windows Adam Baxter
2019-01-31 10:49 ` Daniel P. Berrangé [this message]
2019-01-31 10:54   ` Adam Baxter
2019-01-31 11:19   ` Peter Maydell
2019-01-31 11:28     ` Daniel P. Berrangé
2019-01-31 13:27       ` Stefan Weil
2019-02-13  9:32   ` Daniel P. Berrangé
2019-02-13  9:47     ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131104911.GF19982@redhat.com \
    --to=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=voltagex@voltagex.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).