From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpEBM-0006tm-E7 for qemu-devel@nongnu.org; Thu, 31 Jan 2019 10:23:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpEBL-0001Ad-OT for qemu-devel@nongnu.org; Thu, 31 Jan 2019 10:23:12 -0500 Date: Thu, 31 Jan 2019 15:20:42 +0000 From: Anthony PERARD Message-ID: <20190131152042.GF2306@perard.uk.xensource.com> References: <20190130161948.15888-1-paul.durrant@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190130161948.15888-1-paul.durrant@citrix.com> Subject: Re: [Qemu-devel] [PATCH v2] xen-block: handle resize callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, xen-devel@lists.xenproject.org, Stefan Hajnoczi , Stefano Stabellini , Kevin Wolf , Max Reitz On Wed, Jan 30, 2019 at 04:19:48PM +0000, Paul Durrant wrote: > Some frontend drivers will handle dynamic resizing of PV disks, so set up > the BlockDevOps resize_cb() method during xen_block_realize() to allow > this to be done. > > Signed-off-by: Paul Durrant > --- > + /* > + * Mimic the behaviour of Linux xen-blkback and re-write the state > + * to trigger the frontend watch. > + */ > + xen_device_backend_set_state(xendev, backend_state); :(, that function doesn't write the state again if it hasn't changed. So in my testing, Linux never did anything. -- Anthony PERARD