From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:42848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpUIc-0000W2-2P for qemu-devel@nongnu.org; Fri, 01 Feb 2019 03:35:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpUIb-0003El-6Z for qemu-devel@nongnu.org; Fri, 01 Feb 2019 03:35:46 -0500 Date: Fri, 1 Feb 2019 09:35:24 +0100 From: Cornelia Huck Message-ID: <20190201093524.321787a2.cohuck@redhat.com> In-Reply-To: <4fec7d60-1d09-ba37-c66a-1d86088a1c0e@linux.ibm.com> References: <20190130155733.32742-1-david@redhat.com> <4fec7d60-1d09-ba37-c66a-1d86088a1c0e@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/6] s390x/pci: remaining hot/un)plug patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Collin Walling Cc: David Hildenbrand , qemu-devel@nongnu.org, Thomas Huth , Pierre Morel , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson On Thu, 31 Jan 2019 15:43:16 -0500 Collin Walling wrote: > On 1/30/19 10:57 AM, David Hildenbrand wrote: > > These are all the patches that are not yet upstream (@Conny you might > > already picked some, including them for the full picture) and after > > a good discussion yesterday, including a patch t get rid of the release > > timer. I ran a couple of sanity tests on this series. > > > > #1 and #2 fix hotplugging of PCI bridges. > > #3 warns when "zpci=off" > > #4 refactors unplugging > > #5 get's rid of the release timer > > #6 processes all unplug requests on reboot > > > > @Colin, can you review/ack? Especially Patch #4 is needed for qdev > > patches already on the list. ("[PATCH RFCv2 0/9] qdev: Hotplug handler > > chaining + virtio-pmem") > > I've given my r-b for 4, 5, and 6. IIRC, the other patches in this > series looked fine from previous versions, but I'd like to look at them > more carefully before ack'ing. Please allow me some time to devote to > them in the near future. Trying my best to balance things :) Great, thanks for looking. If patches 4-6 can be applied without patches 1-3 (I think they can?), I'll go ahead and queue them. (I'll probably send a pull request next week, will be happy to include the other patches as well.)