qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH v13 20/31] iotests: Add quorum case to test 110
Date: Fri,  1 Feb 2019 20:29:24 +0100	[thread overview]
Message-ID: <20190201192935.18394-21-mreitz@redhat.com> (raw)
In-Reply-To: <20190201192935.18394-1-mreitz@redhat.com>

Test 110 tests relative backing filenames for complex BDS trees.  Now
that the originally supposedly failing test passes, let us add a new
failing test: Quorum can never work automatically (without detecting
whether all child nodes have the same base directory, but that would be
rather inconsistent behavior).

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
 tests/qemu-iotests/110     | 26 ++++++++++++++++++++++++++
 tests/qemu-iotests/110.out |  7 +++++++
 2 files changed, 33 insertions(+)

diff --git a/tests/qemu-iotests/110 b/tests/qemu-iotests/110
index 3e9d72d302..185ad5437e 100755
--- a/tests/qemu-iotests/110
+++ b/tests/qemu-iotests/110
@@ -29,6 +29,7 @@ status=1	# failure is the default!
 _cleanup()
 {
 	_cleanup_test_img
+        rm -f "$TEST_IMG.copy"
 }
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
@@ -86,6 +87,31 @@ echo
 # omit the image size; it should work anyway
 _make_test_img -b "$TEST_IMG_REL.base"
 
+echo
+echo '=== Nodes without a common directory ==='
+echo
+
+cp "$TEST_IMG" "$TEST_IMG.copy"
+
+# Should inform us that the actual path of the backing file cannot be determined
+TEST_IMG="json:{
+    'driver': '$IMGFMT',
+    'file': {
+        'driver': 'quorum',
+        'vote-threshold': 1,
+        'children': [
+            {
+                'driver': 'file',
+                'filename': '$TEST_IMG'
+            },
+            {
+                'driver': 'file',
+                'filename': '$TEST_IMG.copy'
+            }
+        ]
+    }
+}" _img_info | _filter_img_info
+
 
 # success, all done
 echo '*** done'
diff --git a/tests/qemu-iotests/110.out b/tests/qemu-iotests/110.out
index 5370bc1d26..1d0b2475cc 100644
--- a/tests/qemu-iotests/110.out
+++ b/tests/qemu-iotests/110.out
@@ -19,4 +19,11 @@ backing file: t.IMGFMT.base (actual path: TEST_DIR/t.IMGFMT.base)
 === Backing name is always relative to the backed image ===
 
 Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 backing_file=t.IMGFMT.base
+
+=== Nodes without a common directory ===
+
+image: json:{"driver": "IMGFMT", "file": {"children": [{"driver": "file", "filename": "TEST_DIR/t.IMGFMT"}, {"driver": "file", "filename": "TEST_DIR/t.IMGFMT.copy"}], "driver": "quorum", "blkverify": false, "rewrite-corrupted": false, "vote-threshold": 1}}
+file format: IMGFMT
+virtual size: 64M (67108864 bytes)
+backing file: t.IMGFMT.base (cannot determine actual path)
 *** done
-- 
2.20.1

  parent reply	other threads:[~2019-02-01 19:30 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 19:29 [Qemu-devel] [PATCH v13 00/31] Fix some filename generation issues Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull Max Reitz
2019-02-01 19:52   ` Eric Blake
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 02/31] block: Use children list in bdrv_refresh_filename Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 03/31] block: Skip implicit nodes for filename info Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 04/31] block: Add BDS.auto_backing_file Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 05/31] block: Respect backing bs in bdrv_refresh_filename Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 06/31] iotests.py: Add filter_imgfmt() Max Reitz
2019-02-01 20:02   ` Eric Blake
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 07/31] iotests.py: Add node_info() Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 08/31] iotests: Add test for backing file overrides Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 09/31] block: Make path_combine() return the path Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 10/31] block: bdrv_get_full_backing_filename_from_...'s ret. val Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 11/31] block: bdrv_get_full_backing_filename's " Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 12/31] block: Add bdrv_make_absolute_filename() Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 13/31] block: Fix bdrv_find_backing_image() Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 14/31] block: Add bdrv_dirname() Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 15/31] blkverify: Make bdrv_dirname() return NULL Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 16/31] quorum: " Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 17/31] block/nbd: " Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 18/31] block/nfs: Implement bdrv_dirname() Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 19/31] block: Use bdrv_dirname() for relative filenames Max Reitz
2019-02-01 19:29 ` Max Reitz [this message]
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 21/31] block: Add strong_runtime_opts to BlockDriver Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 22/31] block: Add BlockDriver.bdrv_gather_child_options Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 23/31] block: Generically refresh runtime options Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 24/31] block: Purify .bdrv_refresh_filename() Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 25/31] block: Do not copy exact_filename from format file Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 26/31] block/nvme: Fix bdrv_refresh_filename() Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 27/31] block/curl: Harmonize option defaults Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 28/31] block/curl: Implement bdrv_refresh_filename() Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 29/31] block/null: Generate filename even with latency-ns Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 30/31] block: BDS options may lack the "driver" option Max Reitz
2019-02-01 19:29 ` [Qemu-devel] [PATCH v13 31/31] iotests: Test json:{} filenames of internal BDSs Max Reitz
2019-02-03 16:25 ` [Qemu-devel] [PATCH v13 00/31] Fix some filename generation issues no-reply
2019-02-10 14:31 ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190201192935.18394-21-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).