qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] hw/ppc/spapr: Add support for "-vga cirrus"
@ 2019-01-30 13:36 Thomas Huth
  2019-02-03 23:50 ` David Gibson
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2019-01-30 13:36 UTC (permalink / raw)
  To: qemu-ppc, David Gibson; +Cc: qemu-devel

The cirrus VGA card has been enabled in the PPC builds with
commit 29f9cef39eb1ae55e82c ("ppc: Include vga cirrus card into
the compiling process") last year. It also works on the pseries
machine, even SLOF contains support for this card, so we can
also support this for the "-vga" parameter here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/ppc/spapr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 71fe552..2323974 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1717,6 +1717,7 @@ static bool spapr_vga_init(PCIBus *pci_bus, Error **errp)
         return true;
     case VGA_STD:
     case VGA_VIRTIO:
+    case VGA_CIRRUS:
         return pci_vga_init(pci_bus) != NULL;
     default:
         error_setg(errp,
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Add support for "-vga cirrus"
  2019-01-30 13:36 [Qemu-devel] [PATCH] hw/ppc/spapr: Add support for "-vga cirrus" Thomas Huth
@ 2019-02-03 23:50 ` David Gibson
  0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2019-02-03 23:50 UTC (permalink / raw)
  To: Thomas Huth; +Cc: qemu-ppc, qemu-devel

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

On Wed, Jan 30, 2019 at 02:36:39PM +0100, Thomas Huth wrote:
> The cirrus VGA card has been enabled in the PPC builds with
> commit 29f9cef39eb1ae55e82c ("ppc: Include vga cirrus card into
> the compiling process") last year. It also works on the pseries
> machine, even SLOF contains support for this card, so we can
> also support this for the "-vga" parameter here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Applied to ppc-for-4.0.

> ---
>  hw/ppc/spapr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 71fe552..2323974 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1717,6 +1717,7 @@ static bool spapr_vga_init(PCIBus *pci_bus, Error **errp)
>          return true;
>      case VGA_STD:
>      case VGA_VIRTIO:
> +    case VGA_CIRRUS:
>          return pci_vga_init(pci_bus) != NULL;
>      default:
>          error_setg(errp,

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-04  0:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-30 13:36 [Qemu-devel] [PATCH] hw/ppc/spapr: Add support for "-vga cirrus" Thomas Huth
2019-02-03 23:50 ` David Gibson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).