From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: "Richard Henderson" <rth@twiddle.net>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Michael Walle" <michael@walle.cc>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-ppc@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Joel Stanley" <joel@jms.id.au>,
"Andrzej Zaborowski" <balrogg@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
qemu-arm@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH v2 10/11] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string
Date: Tue, 5 Feb 2019 00:18:14 +0100 [thread overview]
Message-ID: <20190204231815.29661-11-philmd@redhat.com> (raw)
In-Reply-To: <20190204231815.29661-1-philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/arm/exynos4_boards.c | 3 ++-
hw/arm/mps2-tz.c | 3 ++-
hw/net/lan9118.c | 1 -
include/hw/net/lan9118.h | 2 ++
4 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c
index 750162cc95..ea8100f65a 100644
--- a/hw/arm/exynos4_boards.c
+++ b/hw/arm/exynos4_boards.c
@@ -32,6 +32,7 @@
#include "hw/arm/arm.h"
#include "exec/address-spaces.h"
#include "hw/arm/exynos4210.h"
+#include "hw/net/lan9118.h"
#include "hw/boards.h"
#undef DEBUG
@@ -92,7 +93,7 @@ static void lan9215_init(uint32_t base, qemu_irq irq)
/* This should be a 9215 but the 9118 is close enough */
if (nd_table[0].used) {
qemu_check_nic_model(&nd_table[0], "lan9118");
- dev = qdev_create(NULL, "lan9118");
+ dev = qdev_create(NULL, TYPE_LAN9118);
qdev_set_nic_properties(dev, &nd_table[0]);
qdev_prop_set_uint32(dev, "mode_16bit", 1);
qdev_init_nofail(dev);
diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c
index f79f090a4a..7832408bb7 100644
--- a/hw/arm/mps2-tz.c
+++ b/hw/arm/mps2-tz.c
@@ -56,6 +56,7 @@
#include "hw/arm/armsse.h"
#include "hw/dma/pl080.h"
#include "hw/ssi/pl022.h"
+#include "hw/net/lan9118.h"
#include "net/net.h"
#include "hw/core/split-irq.h"
@@ -244,7 +245,7 @@ static MemoryRegion *make_eth_dev(MPS2TZMachineState *mms, void *opaque,
* except that it doesn't support the checksum-offload feature.
*/
qemu_check_nic_model(nd, "lan9118");
- mms->lan9118 = qdev_create(NULL, "lan9118");
+ mms->lan9118 = qdev_create(NULL, TYPE_LAN9118);
qdev_set_nic_properties(mms->lan9118, nd);
qdev_init_nofail(mms->lan9118);
diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c
index a428b16eda..b29e3fee49 100644
--- a/hw/net/lan9118.c
+++ b/hw/net/lan9118.c
@@ -175,7 +175,6 @@ static const VMStateDescription vmstate_lan9118_packet = {
}
};
-#define TYPE_LAN9118 "lan9118"
#define LAN9118(obj) OBJECT_CHECK(lan9118_state, (obj), TYPE_LAN9118)
typedef struct {
diff --git a/include/hw/net/lan9118.h b/include/hw/net/lan9118.h
index d13d8cd3d2..500acb4c14 100644
--- a/include/hw/net/lan9118.h
+++ b/include/hw/net/lan9118.h
@@ -14,6 +14,8 @@
#include "hw/irq.h"
#include "net/net.h"
+#define TYPE_LAN9118 "lan9118"
+
void lan9118_init(NICInfo *, uint32_t, qemu_irq);
#endif
--
2.20.1
next prev parent reply other threads:[~2019-02-04 23:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 23:18 [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 01/11] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string Philippe Mathieu-Daudé
2019-04-08 14:45 ` Markus Armbruster
2019-04-08 14:45 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 02/11] hw: Remove unused 'hw/devices.h' include Philippe Mathieu-Daudé
2019-02-05 0:42 ` David Gibson
2019-04-08 14:42 ` Markus Armbruster
2019-04-08 14:42 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 03/11] hw/devices: Move TC6393XB declarations into a new header Philippe Mathieu-Daudé
2019-04-08 14:57 ` Markus Armbruster
2019-04-08 14:57 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 04/11] hw/devices: Move Blizzard " Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 05/11] hw/devices: Move CBus " Philippe Mathieu-Daudé
2019-04-08 15:02 ` Markus Armbruster
2019-04-08 15:02 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 06/11] hw/devices: Move Gamepad " Philippe Mathieu-Daudé
2019-04-08 15:04 ` Markus Armbruster
2019-04-08 15:04 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 07/11] hw/devices: Move TI touchscreen " Philippe Mathieu-Daudé
2019-04-08 15:10 ` Markus Armbruster
2019-04-08 15:10 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 08/11] hw/devices: Move LAN9118 " Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 09/11] hw/net/ne2000-isa: Add guards to the header Philippe Mathieu-Daudé
2019-02-04 23:18 ` Philippe Mathieu-Daudé [this message]
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 11/11] hw/devices: Move SMSC 91C111 declaration into a new header Philippe Mathieu-Daudé
2019-02-12 12:17 ` [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-04-08 15:22 ` Markus Armbruster
2019-04-08 15:22 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204231815.29661-11-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=andrew@aj.id.au \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=balrogg@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=f4bug@amsat.org \
--cc=i.mitsyanko@gmail.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=michael@walle.cc \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).