qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: "Richard Henderson" <rth@twiddle.net>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Jan Kiszka" <jan.kiszka@web.de>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Michael Walle" <michael@walle.cc>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	qemu-ppc@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Joel Stanley" <joel@jms.id.au>,
	"Andrzej Zaborowski" <balrogg@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	qemu-arm@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
	"Rob Herring" <robh@kernel.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>
Subject: [Qemu-devel] [PATCH v2 05/11] hw/devices: Move CBus declarations into a new header
Date: Tue,  5 Feb 2019 00:18:09 +0100	[thread overview]
Message-ID: <20190204231815.29661-6-philmd@redhat.com> (raw)
In-Reply-To: <20190204231815.29661-1-philmd@redhat.com>

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS            |  1 +
 hw/arm/nseries.c       |  1 +
 hw/misc/cbus.c         |  2 +-
 include/hw/devices.h   | 14 --------------
 include/hw/misc/cbus.h | 32 ++++++++++++++++++++++++++++++++
 5 files changed, 35 insertions(+), 15 deletions(-)
 create mode 100644 include/hw/misc/cbus.h

diff --git a/MAINTAINERS b/MAINTAINERS
index a21e7b546b..daae4a3beb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -654,6 +654,7 @@ F: hw/input/tsc2005.c
 F: hw/misc/cbus.c
 F: hw/timer/twl92230.c
 F: include/hw/display/blizzard.h
+F: include/hw/misc/cbus.h
 
 Palm
 M: Andrzej Zaborowski <balrogg@gmail.com>
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 9521be1cef..ac876b5878 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -32,6 +32,7 @@
 #include "hw/i2c/i2c.h"
 #include "hw/devices.h"
 #include "hw/display/blizzard.h"
+#include "hw/misc/cbus.h"
 #include "hw/block/flash.h"
 #include "hw/hw.h"
 #include "hw/bt.h"
diff --git a/hw/misc/cbus.c b/hw/misc/cbus.c
index 25e337ea77..16ee704bca 100644
--- a/hw/misc/cbus.c
+++ b/hw/misc/cbus.c
@@ -23,7 +23,7 @@
 #include "qemu/osdep.h"
 #include "hw/hw.h"
 #include "hw/irq.h"
-#include "hw/devices.h"
+#include "hw/misc/cbus.h"
 #include "sysemu/sysemu.h"
 
 //#define DEBUG
diff --git a/include/hw/devices.h b/include/hw/devices.h
index 77d6611302..e400f9eac0 100644
--- a/include/hw/devices.h
+++ b/include/hw/devices.h
@@ -29,18 +29,4 @@ void tsc2005_set_transform(void *opaque, MouseTransformInfo *info);
 /* stellaris_input.c */
 void stellaris_gamepad_init(int n, qemu_irq *irq, const int *keycode);
 
-/* cbus.c */
-typedef struct {
-    qemu_irq clk;
-    qemu_irq dat;
-    qemu_irq sel;
-} CBus;
-CBus *cbus_init(qemu_irq dat_out);
-void cbus_attach(CBus *bus, void *slave_opaque);
-
-void *retu_init(qemu_irq irq, int vilma);
-void *tahvo_init(qemu_irq irq, int betty);
-
-void retu_key_event(void *retu, int state);
-
 #endif
diff --git a/include/hw/misc/cbus.h b/include/hw/misc/cbus.h
new file mode 100644
index 0000000000..c899943e03
--- /dev/null
+++ b/include/hw/misc/cbus.h
@@ -0,0 +1,32 @@
+/*
+ * CBUS three-pin bus and the Retu / Betty / Tahvo / Vilma / Avilma /
+ * Hinku / Vinku / Ahne / Pihi chips used in various Nokia platforms.
+ * Based on reverse-engineering of a linux driver.
+ *
+ * Copyright (C) 2008 Nokia Corporation
+ * Written by Andrzej Zaborowski
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#ifndef HW_MISC_CBUS_H
+#define HW_MISC_CBUS_H
+
+#include "hw/irq.h"
+
+typedef struct {
+    qemu_irq clk;
+    qemu_irq dat;
+    qemu_irq sel;
+} CBus;
+
+CBus *cbus_init(qemu_irq dat_out);
+void cbus_attach(CBus *bus, void *slave_opaque);
+
+void *retu_init(qemu_irq irq, int vilma);
+void *tahvo_init(qemu_irq irq, int betty);
+
+void retu_key_event(void *retu, int state);
+
+#endif
-- 
2.20.1

  parent reply	other threads:[~2019-02-04 23:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 23:18 [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 01/11] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string Philippe Mathieu-Daudé
2019-04-08 14:45   ` Markus Armbruster
2019-04-08 14:45     ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 02/11] hw: Remove unused 'hw/devices.h' include Philippe Mathieu-Daudé
2019-02-05  0:42   ` David Gibson
2019-04-08 14:42   ` Markus Armbruster
2019-04-08 14:42     ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 03/11] hw/devices: Move TC6393XB declarations into a new header Philippe Mathieu-Daudé
2019-04-08 14:57   ` Markus Armbruster
2019-04-08 14:57     ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 04/11] hw/devices: Move Blizzard " Philippe Mathieu-Daudé
2019-02-04 23:18 ` Philippe Mathieu-Daudé [this message]
2019-04-08 15:02   ` [Qemu-devel] [PATCH v2 05/11] hw/devices: Move CBus " Markus Armbruster
2019-04-08 15:02     ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 06/11] hw/devices: Move Gamepad " Philippe Mathieu-Daudé
2019-04-08 15:04   ` Markus Armbruster
2019-04-08 15:04     ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 07/11] hw/devices: Move TI touchscreen " Philippe Mathieu-Daudé
2019-04-08 15:10   ` Markus Armbruster
2019-04-08 15:10     ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 08/11] hw/devices: Move LAN9118 " Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 09/11] hw/net/ne2000-isa: Add guards to the header Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 10/11] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 11/11] hw/devices: Move SMSC 91C111 declaration into a new header Philippe Mathieu-Daudé
2019-02-12 12:17 ` [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-04-08 15:22 ` Markus Armbruster
2019-04-08 15:22   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204231815.29661-6-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=andrew@aj.id.au \
    --cc=aurelien@aurel32.net \
    --cc=b.galvani@gmail.com \
    --cc=balaton@eik.bme.hu \
    --cc=balrogg@gmail.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=edgar.iglesias@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=i.mitsyanko@gmail.com \
    --cc=jan.kiszka@web.de \
    --cc=jasowang@redhat.com \
    --cc=joel@jms.id.au \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kraxel@redhat.com \
    --cc=magnus.damm@gmail.com \
    --cc=michael@walle.cc \
    --cc=peter.chubb@nicta.com.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=robh@kernel.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).