From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: "Richard Henderson" <rth@twiddle.net>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Michael Walle" <michael@walle.cc>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-ppc@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Joel Stanley" <joel@jms.id.au>,
"Andrzej Zaborowski" <balrogg@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
qemu-arm@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH v2 06/11] hw/devices: Move Gamepad declarations into a new header
Date: Tue, 5 Feb 2019 00:18:10 +0100 [thread overview]
Message-ID: <20190204231815.29661-7-philmd@redhat.com> (raw)
In-Reply-To: <20190204231815.29661-1-philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
MAINTAINERS | 1 +
hw/arm/stellaris.c | 2 +-
hw/input/stellaris_input.c | 2 +-
include/hw/devices.h | 3 ---
include/hw/input/gamepad.h | 21 +++++++++++++++++++++
5 files changed, 24 insertions(+), 5 deletions(-)
create mode 100644 include/hw/input/gamepad.h
diff --git a/MAINTAINERS b/MAINTAINERS
index daae4a3beb..a38086f767 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -729,6 +729,7 @@ M: Peter Maydell <peter.maydell@linaro.org>
L: qemu-arm@nongnu.org
S: Maintained
F: hw/*/stellaris*
+F: include/hw/input/gamepad.h
Versatile Express
M: Peter Maydell <peter.maydell@linaro.org>
diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
index 442529cc65..24c20bf612 100644
--- a/hw/arm/stellaris.c
+++ b/hw/arm/stellaris.c
@@ -12,7 +12,6 @@
#include "hw/sysbus.h"
#include "hw/ssi/ssi.h"
#include "hw/arm/arm.h"
-#include "hw/devices.h"
#include "qemu/timer.h"
#include "hw/i2c/i2c.h"
#include "net/net.h"
@@ -22,6 +21,7 @@
#include "sysemu/sysemu.h"
#include "hw/arm/armv7m.h"
#include "hw/char/pl011.h"
+#include "hw/input/gamepad.h"
#include "hw/misc/unimp.h"
#include "cpu.h"
diff --git a/hw/input/stellaris_input.c b/hw/input/stellaris_input.c
index 99168bfeef..20c87d86f4 100644
--- a/hw/input/stellaris_input.c
+++ b/hw/input/stellaris_input.c
@@ -8,7 +8,7 @@
*/
#include "qemu/osdep.h"
#include "hw/hw.h"
-#include "hw/devices.h"
+#include "hw/input/gamepad.h"
#include "ui/console.h"
typedef struct {
diff --git a/include/hw/devices.h b/include/hw/devices.h
index e400f9eac0..7a630da47f 100644
--- a/include/hw/devices.h
+++ b/include/hw/devices.h
@@ -26,7 +26,4 @@ void *tsc2005_init(qemu_irq pintdav);
uint32_t tsc2005_txrx(void *opaque, uint32_t value, int len);
void tsc2005_set_transform(void *opaque, MouseTransformInfo *info);
-/* stellaris_input.c */
-void stellaris_gamepad_init(int n, qemu_irq *irq, const int *keycode);
-
#endif
diff --git a/include/hw/input/gamepad.h b/include/hw/input/gamepad.h
new file mode 100644
index 0000000000..112bad5e4c
--- /dev/null
+++ b/include/hw/input/gamepad.h
@@ -0,0 +1,21 @@
+/*
+ * Gamepad style buttons connected to IRQ/GPIO lines
+ *
+ * Copyright (c) 2007 CodeSourcery.
+ * Written by Paul Brook
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#ifndef HW_INPUT_GAMEPAD_H
+#define HW_INPUT_GAMEPAD_H
+
+/* Gamepad devices that have nowhere better to go. */
+
+#include "hw/irq.h"
+
+/* stellaris_input.c */
+void stellaris_gamepad_init(int n, qemu_irq *irq, const int *keycode);
+
+#endif
--
2.20.1
next prev parent reply other threads:[~2019-02-04 23:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 23:18 [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 01/11] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string Philippe Mathieu-Daudé
2019-04-08 14:45 ` Markus Armbruster
2019-04-08 14:45 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 02/11] hw: Remove unused 'hw/devices.h' include Philippe Mathieu-Daudé
2019-02-05 0:42 ` David Gibson
2019-04-08 14:42 ` Markus Armbruster
2019-04-08 14:42 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 03/11] hw/devices: Move TC6393XB declarations into a new header Philippe Mathieu-Daudé
2019-04-08 14:57 ` Markus Armbruster
2019-04-08 14:57 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 04/11] hw/devices: Move Blizzard " Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 05/11] hw/devices: Move CBus " Philippe Mathieu-Daudé
2019-04-08 15:02 ` Markus Armbruster
2019-04-08 15:02 ` Markus Armbruster
2019-02-04 23:18 ` Philippe Mathieu-Daudé [this message]
2019-04-08 15:04 ` [Qemu-devel] [PATCH v2 06/11] hw/devices: Move Gamepad " Markus Armbruster
2019-04-08 15:04 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 07/11] hw/devices: Move TI touchscreen " Philippe Mathieu-Daudé
2019-04-08 15:10 ` Markus Armbruster
2019-04-08 15:10 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 08/11] hw/devices: Move LAN9118 " Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 09/11] hw/net/ne2000-isa: Add guards to the header Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 10/11] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 11/11] hw/devices: Move SMSC 91C111 declaration into a new header Philippe Mathieu-Daudé
2019-02-12 12:17 ` [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-04-08 15:22 ` Markus Armbruster
2019-04-08 15:22 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204231815.29661-7-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=andrew@aj.id.au \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=balrogg@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=f4bug@amsat.org \
--cc=i.mitsyanko@gmail.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=michael@walle.cc \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).