From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: "Eric Blake" <eblake@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH v3 1/8] ahci-test: Add dependency to qemu-img tool
Date: Tue, 5 Feb 2019 01:18:28 +0100 [thread overview]
Message-ID: <20190205001835.25660-2-philmd@redhat.com> (raw)
In-Reply-To: <20190205001835.25660-1-philmd@redhat.com>
Since the ahci-test uses qemu-img, add a dependency to build it
before using it.
This fixes:
$ gmake check-qtest V=1
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/ahci-test
Failed to execute child process "/tmp/qemu-test.19tMRF/qemu-img" (No such file or directory)
ERROR:tests/libqos/libqos.c:192:mkimg: assertion failed: (ret && !err)
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Slighly related is when vm-tests expect qemu-img available:
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg08415.html
$ make vm-build-ubuntu.i386
Traceback (most recent call last):
File "source/qemu/tests/vm/basevm.py", line 236, in main
return vm.build_image(args.image)
File "tests/vm/ubuntu.i386", line 67, in build_image
subprocess.check_call(["qemu-img", "resize", img_tmp, "50G"])
OSError: [Errno 2] No such file or directory
tests/vm/Makefile.include:23: recipe for target 'tests/vm/ubuntu.i386.img' failed
make: *** [tests/vm/ubuntu.i386.img] Error 2
A better fix would be checking those tools via ./configure...
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 75ad9c0dd3..679656b64a 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -708,7 +708,7 @@ tests/prom-env-test$(EXESUF): tests/prom-env-test.o $(libqos-obj-y)
tests/rtas-test$(EXESUF): tests/rtas-test.o $(libqos-spapr-obj-y)
tests/fdc-test$(EXESUF): tests/fdc-test.o
tests/ide-test$(EXESUF): tests/ide-test.o $(libqos-pc-obj-y)
-tests/ahci-test$(EXESUF): tests/ahci-test.o $(libqos-pc-obj-y)
+tests/ahci-test$(EXESUF): tests/ahci-test.o $(libqos-pc-obj-y) qemu-img$(EXESUF)
tests/ipmi-kcs-test$(EXESUF): tests/ipmi-kcs-test.o
tests/ipmi-bt-test$(EXESUF): tests/ipmi-bt-test.o
tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o
--
2.20.1
next prev parent reply other threads:[~2019-02-05 0:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 0:18 [Qemu-devel] [PATCH v3 0/8] OpenBSD: Block layer fixes (was 'Enable qtesting') Philippe Mathieu-Daudé
2019-02-05 0:18 ` Philippe Mathieu-Daudé [this message]
2019-02-07 16:50 ` [Qemu-devel] [PATCH v3 1/8] ahci-test: Add dependency to qemu-img tool Philippe Mathieu-Daudé
2019-02-07 18:51 ` Thomas Huth
2019-02-08 22:34 ` John Snow
2019-02-08 22:44 ` Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 2/8] qemu-iotests: Add dependency to qemu-nbd tool Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 3/8] qemu-iotests: Improve portability by searching bash in the $PATH Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 4/8] qemu-iotests: Ensure GNU sed is used Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 5/8] iotests: Let verify_platform() check for unsupported platforms Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 6/8] RFC iotests: Disable 208 on OpenBSD Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 7/8] RFC iotests: Disable 209 " Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 8/8] RFC iotests: Disable 236 and 238 " Philippe Mathieu-Daudé
2019-02-05 0:33 ` John Snow
2019-02-13 17:12 ` Christian Borntraeger
2019-02-05 0:30 ` [Qemu-devel] [PATCH v3 0/8] OpenBSD: Block layer fixes (was 'Enable qtesting') no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205001835.25660-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).