From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: "Eric Blake" <eblake@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH v3 2/8] qemu-iotests: Add dependency to qemu-nbd tool
Date: Tue, 5 Feb 2019 01:18:29 +0100 [thread overview]
Message-ID: <20190205001835.25660-3-philmd@redhat.com> (raw)
In-Reply-To: <20190205001835.25660-1-philmd@redhat.com>
Since a9660664fde, some iotests use qemu-nbd.
Add a dependency to build it before using it.
This fixes:
$ make check-block
GEN qemu-img-cmds.h
CC qemu-img.o
LINK qemu-img
CC qemu-io.o
LINK qemu-io
CC tests/qemu-iotests/socket_scm_helper.o
LINK tests/qemu-iotests/socket_scm_helper
tests/qemu-iotests-quick.sh
check: qemu-nbd not found
make: *** [tests/Makefile.include:1059: check-tests/qemu-iotests-quick.sh] Error 1
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 679656b64a..c31b87a41f 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -1057,7 +1057,7 @@ clean-tcg: $(CLEAN_TCG_TARGET_RULES)
QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu-iotests/socket_scm_helper$(EXESUF)
.PHONY: check-tests/qemu-iotests-quick.sh
-check-tests/qemu-iotests-quick.sh: tests/qemu-iotests-quick.sh qemu-img$(EXESUF) qemu-io$(EXESUF) $(QEMU_IOTESTS_HELPERS-y)
+check-tests/qemu-iotests-quick.sh: tests/qemu-iotests-quick.sh qemu-img$(EXESUF) qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y)
$<
.PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
--
2.20.1
next prev parent reply other threads:[~2019-02-05 0:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 0:18 [Qemu-devel] [PATCH v3 0/8] OpenBSD: Block layer fixes (was 'Enable qtesting') Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 1/8] ahci-test: Add dependency to qemu-img tool Philippe Mathieu-Daudé
2019-02-07 16:50 ` Philippe Mathieu-Daudé
2019-02-07 18:51 ` Thomas Huth
2019-02-08 22:34 ` John Snow
2019-02-08 22:44 ` Philippe Mathieu-Daudé
2019-02-05 0:18 ` Philippe Mathieu-Daudé [this message]
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 3/8] qemu-iotests: Improve portability by searching bash in the $PATH Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 4/8] qemu-iotests: Ensure GNU sed is used Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 5/8] iotests: Let verify_platform() check for unsupported platforms Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 6/8] RFC iotests: Disable 208 on OpenBSD Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 7/8] RFC iotests: Disable 209 " Philippe Mathieu-Daudé
2019-02-05 0:18 ` [Qemu-devel] [PATCH v3 8/8] RFC iotests: Disable 236 and 238 " Philippe Mathieu-Daudé
2019-02-05 0:33 ` John Snow
2019-02-13 17:12 ` Christian Borntraeger
2019-02-05 0:30 ` [Qemu-devel] [PATCH v3 0/8] OpenBSD: Block layer fixes (was 'Enable qtesting') no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205001835.25660-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).