From: David Gibson <david@gibson.dropbear.id.au>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
"Richard Henderson" <rth@twiddle.net>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Michael Walle" <michael@walle.cc>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-ppc@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Joel Stanley" <joel@jms.id.au>,
"Andrzej Zaborowski" <balrogg@gmail.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
qemu-arm@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
"Rob Herring" <robh@kernel.org>, "Thomas Huth" <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 02/11] hw: Remove unused 'hw/devices.h' include
Date: Tue, 5 Feb 2019 11:42:35 +1100 [thread overview]
Message-ID: <20190205004235.GA22661@umbus.fritz.box> (raw)
In-Reply-To: <20190204231815.29661-3-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 10270 bytes --]
On Tue, Feb 05, 2019 at 12:18:06AM +0100, Philippe Mathieu-Daudé wrote:
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> Tested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
ppc parts
Acked-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/alpha/typhoon.c | 1 -
> hw/arm/allwinner-a10.c | 1 -
> hw/arm/collie.c | 1 -
> hw/arm/cubieboard.c | 1 -
> hw/arm/highbank.c | 1 -
> hw/arm/mps2-tz.c | 1 -
> hw/arm/musicpal.c | 1 -
> hw/arm/nrf51_soc.c | 1 -
> hw/arm/spitz.c | 1 -
> hw/arm/virt.c | 1 -
> hw/arm/z2.c | 1 -
> hw/display/sm501.c | 1 -
> hw/hppa/dino.c | 1 -
> hw/intc/allwinner-a10-pic.c | 1 -
> hw/lm32/lm32_boards.c | 1 -
> hw/lm32/milkymist.c | 1 -
> hw/microblaze/petalogix_ml605_mmu.c | 1 -
> hw/microblaze/petalogix_s3adsp1800_mmu.c | 1 -
> hw/net/dp8393x.c | 1 -
> hw/ppc/virtex_ml507.c | 1 -
> hw/sh4/r2d.c | 1 -
> hw/tricore/tricore_testboard.c | 1 -
> hw/usb/tusb6010.c | 1 -
> 23 files changed, 23 deletions(-)
>
> diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c
> index 397e2dcdc7..9d57361c67 100644
> --- a/hw/alpha/typhoon.c
> +++ b/hw/alpha/typhoon.c
> @@ -11,7 +11,6 @@
> #include "qapi/error.h"
> #include "cpu.h"
> #include "hw/hw.h"
> -#include "hw/devices.h"
> #include "sysemu/sysemu.h"
> #include "alpha_sys.h"
> #include "exec/address-spaces.h"
> diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
> index df0d079ad0..06ec6f4dc8 100644
> --- a/hw/arm/allwinner-a10.c
> +++ b/hw/arm/allwinner-a10.c
> @@ -20,7 +20,6 @@
> #include "qemu-common.h"
> #include "cpu.h"
> #include "hw/sysbus.h"
> -#include "hw/devices.h"
> #include "hw/arm/allwinner-a10.h"
> #include "hw/misc/unimp.h"
>
> diff --git a/hw/arm/collie.c b/hw/arm/collie.c
> index 48b732c176..3ca4e078fe 100644
> --- a/hw/arm/collie.c
> +++ b/hw/arm/collie.c
> @@ -12,7 +12,6 @@
> #include "hw/hw.h"
> #include "hw/sysbus.h"
> #include "hw/boards.h"
> -#include "hw/devices.h"
> #include "strongarm.h"
> #include "hw/arm/arm.h"
> #include "hw/block/flash.h"
> diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c
> index 32f1edd2fa..84187d3916 100644
> --- a/hw/arm/cubieboard.c
> +++ b/hw/arm/cubieboard.c
> @@ -20,7 +20,6 @@
> #include "qemu-common.h"
> #include "cpu.h"
> #include "hw/sysbus.h"
> -#include "hw/devices.h"
> #include "hw/boards.h"
> #include "hw/arm/allwinner-a10.h"
>
> diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
> index fb9efa02c3..96ccf18d86 100644
> --- a/hw/arm/highbank.c
> +++ b/hw/arm/highbank.c
> @@ -21,7 +21,6 @@
> #include "qapi/error.h"
> #include "hw/sysbus.h"
> #include "hw/arm/arm.h"
> -#include "hw/devices.h"
> #include "hw/loader.h"
> #include "net/net.h"
> #include "sysemu/kvm.h"
> diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c
> index f5f0b0e0fa..f79f090a4a 100644
> --- a/hw/arm/mps2-tz.c
> +++ b/hw/arm/mps2-tz.c
> @@ -56,7 +56,6 @@
> #include "hw/arm/armsse.h"
> #include "hw/dma/pl080.h"
> #include "hw/ssi/pl022.h"
> -#include "hw/devices.h"
> #include "net/net.h"
> #include "hw/core/split-irq.h"
>
> diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
> index d22532a11c..de4a12e496 100644
> --- a/hw/arm/musicpal.c
> +++ b/hw/arm/musicpal.c
> @@ -15,7 +15,6 @@
> #include "cpu.h"
> #include "hw/sysbus.h"
> #include "hw/arm/arm.h"
> -#include "hw/devices.h"
> #include "net/net.h"
> #include "sysemu/sysemu.h"
> #include "hw/boards.h"
> diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c
> index bbaf050103..3e633d160e 100644
> --- a/hw/arm/nrf51_soc.c
> +++ b/hw/arm/nrf51_soc.c
> @@ -14,7 +14,6 @@
> #include "hw/arm/arm.h"
> #include "hw/sysbus.h"
> #include "hw/boards.h"
> -#include "hw/devices.h"
> #include "hw/misc/unimp.h"
> #include "exec/address-spaces.h"
> #include "sysemu/sysemu.h"
> diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c
> index c4bc3deedf..22f5958b9d 100644
> --- a/hw/arm/spitz.c
> +++ b/hw/arm/spitz.c
> @@ -21,7 +21,6 @@
> #include "hw/ssi/ssi.h"
> #include "hw/block/flash.h"
> #include "qemu/timer.h"
> -#include "hw/devices.h"
> #include "hw/arm/sharpsl.h"
> #include "ui/console.h"
> #include "hw/audio/wm8750.h"
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 99c2b6e60d..396804f0e5 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -37,7 +37,6 @@
> #include "hw/vfio/vfio-calxeda-xgmac.h"
> #include "hw/vfio/vfio-amd-xgbe.h"
> #include "hw/display/ramfb.h"
> -#include "hw/devices.h"
> #include "net/net.h"
> #include "sysemu/device_tree.h"
> #include "sysemu/numa.h"
> diff --git a/hw/arm/z2.c b/hw/arm/z2.c
> index 697a822f1e..7afa352a96 100644
> --- a/hw/arm/z2.c
> +++ b/hw/arm/z2.c
> @@ -15,7 +15,6 @@
> #include "hw/hw.h"
> #include "hw/arm/pxa.h"
> #include "hw/arm/arm.h"
> -#include "hw/devices.h"
> #include "hw/i2c/i2c.h"
> #include "hw/ssi/ssi.h"
> #include "hw/boards.h"
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 4a8686f0f5..2122291308 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -32,7 +32,6 @@
> #include "hw/hw.h"
> #include "hw/char/serial.h"
> #include "ui/console.h"
> -#include "hw/devices.h"
> #include "hw/sysbus.h"
> #include "hw/pci/pci.h"
> #include "hw/i2c/i2c.h"
> diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
> index 31e09942b5..25c3178097 100644
> --- a/hw/hppa/dino.c
> +++ b/hw/hppa/dino.c
> @@ -15,7 +15,6 @@
> #include "qapi/error.h"
> #include "cpu.h"
> #include "hw/hw.h"
> -#include "hw/devices.h"
> #include "sysemu/sysemu.h"
> #include "hw/pci/pci.h"
> #include "hw/pci/pci_bus.h"
> diff --git a/hw/intc/allwinner-a10-pic.c b/hw/intc/allwinner-a10-pic.c
> index 11f13663c8..1aa628cbbb 100644
> --- a/hw/intc/allwinner-a10-pic.c
> +++ b/hw/intc/allwinner-a10-pic.c
> @@ -17,7 +17,6 @@
>
> #include "qemu/osdep.h"
> #include "hw/sysbus.h"
> -#include "hw/devices.h"
> #include "sysemu/sysemu.h"
> #include "hw/intc/allwinner-a10-pic.h"
> #include "qemu/log.h"
> diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c
> index fd8eccca14..6b2fac55fb 100644
> --- a/hw/lm32/lm32_boards.c
> +++ b/hw/lm32/lm32_boards.c
> @@ -25,7 +25,6 @@
> #include "hw/sysbus.h"
> #include "hw/hw.h"
> #include "hw/block/flash.h"
> -#include "hw/devices.h"
> #include "hw/boards.h"
> #include "hw/loader.h"
> #include "elf.h"
> diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
> index 26a2398354..be351d96dc 100644
> --- a/hw/lm32/milkymist.c
> +++ b/hw/lm32/milkymist.c
> @@ -27,7 +27,6 @@
> #include "hw/block/flash.h"
> #include "sysemu/sysemu.h"
> #include "sysemu/qtest.h"
> -#include "hw/devices.h"
> #include "hw/boards.h"
> #include "hw/loader.h"
> #include "elf.h"
> diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c
> index c730878d25..18048d3555 100644
> --- a/hw/microblaze/petalogix_ml605_mmu.c
> +++ b/hw/microblaze/petalogix_ml605_mmu.c
> @@ -35,7 +35,6 @@
> #include "net/net.h"
> #include "hw/block/flash.h"
> #include "sysemu/sysemu.h"
> -#include "hw/devices.h"
> #include "hw/boards.h"
> #include "hw/char/serial.h"
> #include "exec/address-spaces.h"
> diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c b/hw/microblaze/petalogix_s3adsp1800_mmu.c
> index b9f0b0d06e..a0edaf867c 100644
> --- a/hw/microblaze/petalogix_s3adsp1800_mmu.c
> +++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c
> @@ -33,7 +33,6 @@
> #include "net/net.h"
> #include "hw/block/flash.h"
> #include "sysemu/sysemu.h"
> -#include "hw/devices.h"
> #include "hw/boards.h"
> #include "hw/misc/unimp.h"
> #include "exec/address-spaces.h"
> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
> index b53fcaa8bc..98cb4e58c7 100644
> --- a/hw/net/dp8393x.c
> +++ b/hw/net/dp8393x.c
> @@ -19,7 +19,6 @@
>
> #include "qemu/osdep.h"
> #include "hw/sysbus.h"
> -#include "hw/devices.h"
> #include "net/net.h"
> #include "qapi/error.h"
> #include "qemu/timer.h"
> diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
> index 5177120574..8142d68ca2 100644
> --- a/hw/ppc/virtex_ml507.c
> +++ b/hw/ppc/virtex_ml507.c
> @@ -31,7 +31,6 @@
> #include "hw/block/flash.h"
> #include "sysemu/sysemu.h"
> #include "sysemu/qtest.h"
> -#include "hw/devices.h"
> #include "hw/boards.h"
> #include "sysemu/device_tree.h"
> #include "hw/loader.h"
> diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
> index 5b399e7161..bbcf3eda33 100644
> --- a/hw/sh4/r2d.c
> +++ b/hw/sh4/r2d.c
> @@ -31,7 +31,6 @@
> #include "hw/sysbus.h"
> #include "hw/hw.h"
> #include "hw/sh4/sh.h"
> -#include "hw/devices.h"
> #include "sysemu/sysemu.h"
> #include "hw/boards.h"
> #include "hw/pci/pci.h"
> diff --git a/hw/tricore/tricore_testboard.c b/hw/tricore/tricore_testboard.c
> index a58096f05e..364321735a 100644
> --- a/hw/tricore/tricore_testboard.c
> +++ b/hw/tricore/tricore_testboard.c
> @@ -24,7 +24,6 @@
> #include "qemu-common.h"
> #include "cpu.h"
> #include "hw/hw.h"
> -#include "hw/devices.h"
> #include "net/net.h"
> #include "sysemu/sysemu.h"
> #include "hw/boards.h"
> diff --git a/hw/usb/tusb6010.c b/hw/usb/tusb6010.c
> index 501706e2b2..f76b59afe8 100644
> --- a/hw/usb/tusb6010.c
> +++ b/hw/usb/tusb6010.c
> @@ -24,7 +24,6 @@
> #include "hw/usb.h"
> #include "hw/arm/omap.h"
> #include "hw/irq.h"
> -#include "hw/devices.h"
> #include "hw/sysbus.h"
>
> #define TYPE_TUSB6010 "tusb6010"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-05 2:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 23:18 [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 01/11] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string Philippe Mathieu-Daudé
2019-04-08 14:45 ` Markus Armbruster
2019-04-08 14:45 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 02/11] hw: Remove unused 'hw/devices.h' include Philippe Mathieu-Daudé
2019-02-05 0:42 ` David Gibson [this message]
2019-04-08 14:42 ` Markus Armbruster
2019-04-08 14:42 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 03/11] hw/devices: Move TC6393XB declarations into a new header Philippe Mathieu-Daudé
2019-04-08 14:57 ` Markus Armbruster
2019-04-08 14:57 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 04/11] hw/devices: Move Blizzard " Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 05/11] hw/devices: Move CBus " Philippe Mathieu-Daudé
2019-04-08 15:02 ` Markus Armbruster
2019-04-08 15:02 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 06/11] hw/devices: Move Gamepad " Philippe Mathieu-Daudé
2019-04-08 15:04 ` Markus Armbruster
2019-04-08 15:04 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 07/11] hw/devices: Move TI touchscreen " Philippe Mathieu-Daudé
2019-04-08 15:10 ` Markus Armbruster
2019-04-08 15:10 ` Markus Armbruster
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 08/11] hw/devices: Move LAN9118 " Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 09/11] hw/net/ne2000-isa: Add guards to the header Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 10/11] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string Philippe Mathieu-Daudé
2019-02-04 23:18 ` [Qemu-devel] [PATCH v2 11/11] hw/devices: Move SMSC 91C111 declaration into a new header Philippe Mathieu-Daudé
2019-02-12 12:17 ` [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-04-08 15:22 ` Markus Armbruster
2019-04-08 15:22 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205004235.GA22661@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=andrew@aj.id.au \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=balrogg@gmail.com \
--cc=clg@kaod.org \
--cc=edgar.iglesias@gmail.com \
--cc=f4bug@amsat.org \
--cc=i.mitsyanko@gmail.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=michael@walle.cc \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).