qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 10/14] sdl2: use only QKeyCode in sdl2_process_key()
Date: Tue,  5 Feb 2019 11:57:54 +0100	[thread overview]
Message-ID: <20190205105758.4230-11-kraxel@redhat.com> (raw)
In-Reply-To: <20190205105758.4230-1-kraxel@redhat.com>

Also: sdl2_process_key is never called with scon == NULL.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20190122092814.14919-5-kraxel@redhat.com
---
 ui/sdl2-input.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c
index 22e3336aab..664364a5e5 100644
--- a/ui/sdl2-input.c
+++ b/ui/sdl2-input.c
@@ -34,20 +34,19 @@ void sdl2_process_key(struct sdl2_console *scon,
                       SDL_KeyboardEvent *ev)
 {
     int qcode;
-    QemuConsole *con = scon ? scon->dcl.con : NULL;
+    QemuConsole *con = scon->dcl.con;
 
     if (ev->keysym.scancode >= qemu_input_map_usb_to_qcode_len) {
         return;
     }
-
     qcode = qemu_input_map_usb_to_qcode[ev->keysym.scancode];
     qkbd_state_key_event(scon->kbd, qcode, ev->type == SDL_KEYDOWN);
 
     if (!qemu_console_is_graphic(con)) {
         bool ctrl = qkbd_state_modifier_get(scon->kbd, QKBD_MOD_CTRL);
         if (ev->type == SDL_KEYDOWN) {
-            switch (ev->keysym.scancode) {
-            case SDL_SCANCODE_RETURN:
+            switch (qcode) {
+            case Q_KEY_CODE_RET:
                 kbd_put_keysym_console(con, '\n');
                 break;
             default:
-- 
2.9.3

  parent reply	other threads:[~2019-02-05 10:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 10:57 [Qemu-devel] [PULL 00/14] Ui 20190205 patches Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 01/14] Remove deprecated -no-frame option Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 02/14] ui: don't send any event if delta_y == 0 Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 03/14] ui: listen for GDK_SMOOTH_SCROLL events Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 04/14] ui/sdl_keysym: Remove obsolete SDL1.2 related code Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 05/14] ui/cocoa.m: Fix macOS 10.14 deprecation warnings Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 06/14] ui/egl-helpers: Augment parameter list of egl_texture_blend() to convey scales of viewport Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 07/14] kbd-state: add keyboard state tracker Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 08/14] sdl2: remove sdl2_reset_keys() function Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 09/14] kbd-state: use state tracker for sdl2 Gerd Hoffmann
2019-02-05 10:57 ` Gerd Hoffmann [this message]
2019-02-05 10:57 ` [Qemu-devel] [PULL 11/14] kbd-state: use state tracker for gtk Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 12/14] kbd-state: use state tracker for vnc Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 13/14] keymap: pass full keyboard state to keysym2scancode Gerd Hoffmann
2019-02-05 10:57 ` [Qemu-devel] [PULL 14/14] keymap: fix keyup mappings Gerd Hoffmann
2019-02-05 16:51 ` [Qemu-devel] [PULL 00/14] Ui 20190205 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190205105758.4230-11-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).