From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqy8t-0003Nn-6x for qemu-devel@nongnu.org; Tue, 05 Feb 2019 05:39:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqy8r-0001zk-U3 for qemu-devel@nongnu.org; Tue, 05 Feb 2019 05:39:50 -0500 Date: Tue, 5 Feb 2019 11:32:19 +0100 From: Cornelia Huck Message-ID: <20190205113219.0c1311e0.cohuck@redhat.com> In-Reply-To: <20190204211204.27321-3-philmd@redhat.com> References: <20190204211204.27321-1-philmd@redhat.com> <20190204211204.27321-3-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/3] util/cutils: Move ctype macros to "cutils.h" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Stefano Garzarella , David Gibson , Halil Pasic , Christian Borntraeger , Richard Henderson , David Hildenbrand , Paolo Bonzini , Fam Zheng , Markus Armbruster , Michael Roth , Michael Clark , Palmer Dabbelt , Alistair Francis , Sagar Karandikar , Bastian Koppelmann , Gerd Hoffmann , "open list:S390 Virtio-ccw" , qemu-ppc@nongnu.org On Mon, 4 Feb 2019 22:12:03 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > Introduced in cd390083ad1, these macros don't need to be in > a generic header. > Add documentation to justify their use. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Stefano Garzarella > Reviewed-by: David Gibson > --- > v2: Fixed checkpatch warnings (tabs) > --- > hw/core/bus.c | 2 +- > hw/core/qdev-properties.c | 1 + > hw/s390x/s390-virtio-ccw.c | 1 + > hw/scsi/scsi-generic.c | 2 +- > include/qemu-common.h | 16 ---------------- > include/qemu/cutils.h | 25 +++++++++++++++++++++++++ > qapi/qapi-util.c | 2 +- > qobject/json-parser.c | 1 - > target/ppc/monitor.c | 1 + > target/riscv/cpu.c | 1 + > ui/keymaps.c | 1 + > util/id.c | 2 +- > util/readline.c | 1 - > 13 files changed, 34 insertions(+), 22 deletions(-) > diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h > index 9ee40470e3..644f2d75bd 100644 > --- a/include/qemu/cutils.h > +++ b/include/qemu/cutils.h > @@ -3,6 +3,31 @@ > =20 > #include "qemu/fprintf-fn.h" > =20 > +/** > + * unsigned ctype macros: > + * > + * The standards require that the argument for these functions > + * is either EOF or a value that is representable in the type > + * unsigned char. If the argument is of type char, it must be > + * cast to unsigned char. This is what these macros do, > + * avoiding 'signed to unsigned' conversion warnings. I'd add "Note that these macros are intended for use with char arguments only, they cannot handle EOF." > + */ > +#define qemu_isalnum(c) isalnum((unsigned char)(c)) > +#define qemu_isalpha(c) isalpha((unsigned char)(c)) > +#define qemu_iscntrl(c) iscntrl((unsigned char)(c)) > +#define qemu_isdigit(c) isdigit((unsigned char)(c)) > +#define qemu_isgraph(c) isgraph((unsigned char)(c)) > +#define qemu_islower(c) islower((unsigned char)(c)) > +#define qemu_isprint(c) isprint((unsigned char)(c)) > +#define qemu_ispunct(c) ispunct((unsigned char)(c)) > +#define qemu_isspace(c) isspace((unsigned char)(c)) > +#define qemu_isupper(c) isupper((unsigned char)(c)) > +#define qemu_isxdigit(c) isxdigit((unsigned char)(c)) > +#define qemu_tolower(c) tolower((unsigned char)(c)) > +#define qemu_toupper(c) toupper((unsigned char)(c)) > +#define qemu_isascii(c) isascii((unsigned char)(c)) > +#define qemu_toascii(c) toascii((unsigned char)(c)) > + > /** > * pstrcpy: > * @buf: buffer to copy string into With that added, Reviewed-by: Cornelia Huck