qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Igor Mammedov <imammedo@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PULL 02/10] s390x: remove direct reference to mem_path global from s390x code
Date: Tue,  5 Feb 2019 17:41:01 +0100	[thread overview]
Message-ID: <20190205164109.25413-3-cohuck@redhat.com> (raw)
In-Reply-To: <20190205164109.25413-1-cohuck@redhat.com>

From: Igor Mammedov <imammedo@redhat.com>

I plan to deprecate -mem-path option and replace it with memory-backend,
for that it's necessary to get rid of mem_path global variable.
Do it for s390x case, replacing it with alternative way to enable
1Mb hugepages capability.

Todo that replace qemu_mempath_getpagesize() with qemu_getrampagesize()
which also checks for -mem-path provided RAM.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <1548834906-133241-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/kvm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 2ebf26adfe..8613e19d11 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -42,6 +42,7 @@
 #include "hw/hw.h"
 #include "sysemu/device_tree.h"
 #include "exec/gdbstub.h"
+#include "exec/ram_addr.h"
 #include "trace.h"
 #include "hw/s390x/s390-pci-inst.h"
 #include "hw/s390x/s390-pci-bus.h"
@@ -287,7 +288,7 @@ void kvm_s390_crypto_reset(void)
 
 static int kvm_s390_configure_mempath_backing(KVMState *s)
 {
-    size_t path_psize = qemu_mempath_getpagesize(mem_path);
+    size_t path_psize = qemu_getrampagesize();
 
     if (path_psize == 4 * KiB) {
         return 0;
@@ -319,7 +320,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
 {
     MachineClass *mc = MACHINE_GET_CLASS(ms);
 
-    if (mem_path && kvm_s390_configure_mempath_backing(s)) {
+    if (kvm_s390_configure_mempath_backing(s)) {
         return -EINVAL;
     }
 
-- 
2.17.2

  parent reply	other threads:[~2019-02-05 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 16:40 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
2019-02-05 16:41 ` [Qemu-devel] [PULL 01/10] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG Cornelia Huck
2019-02-05 16:41 ` Cornelia Huck [this message]
2019-02-05 16:41 ` [Qemu-devel] [PULL 03/10] s390x/pci: Introduce unplug requests and split unplug handler Cornelia Huck
2019-02-05 16:41 ` [Qemu-devel] [PULL 04/10] s390x/pci: Drop release timer and replace it with a flag Cornelia Huck
2019-02-05 16:41 ` [Qemu-devel] [PULL 05/10] s390x/pci: mark zpci devices as unmigratable Cornelia Huck
2019-02-05 16:41 ` [Qemu-devel] [PULL 06/10] s390x/tcg: Don't model FP registers as globals Cornelia Huck
2019-02-05 16:41 ` [Qemu-devel] [PULL 07/10] s390x/pci: Fix primary bus number for PCI bridges Cornelia Huck
2019-02-05 16:41 ` [Qemu-devel] [PULL 08/10] s390x/pci: Fix hotplugging of " Cornelia Huck
2019-02-05 16:41 ` [Qemu-devel] [PULL 09/10] s390x/pci: Warn when adding PCI devices without the 'zpci' feature Cornelia Huck
2019-02-05 16:41 ` [Qemu-devel] [PULL 10/10] s390x/pci: Unplug remaining requested devices on pcihost reset Cornelia Huck
2019-02-05 18:21 ` [Qemu-devel] [PULL 00/10] s390x update Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190205164109.25413-3-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).