From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paulo Neves <ptsneves@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] chardev: Allow for pty path passing.
Date: Wed, 6 Feb 2019 15:36:31 +0000 [thread overview]
Message-ID: <20190206153631.GS12331@redhat.com> (raw)
In-Reply-To: <1548509635-15776-1-git-send-email-ptsneves@gmail.com>
On Sat, Jan 26, 2019 at 02:33:55PM +0100, Paulo Neves wrote:
> If a user requires a virtual serial device like provided
> by the pty char device, the user needs to accept the
> returned device name. This makes the program need to
> have smarts to parse or communicate with qemu to get the
> pty device.
> With this patch the program can pass the path where
> a symlink to the pty device will be, removing the
> need for 2 way communication or smarts.
>
> Signed-off-by: Paulo Neves <ptsneves@gmail.com>
> ---
> chardev/char-pty.c | 41 ++++++++++++++++++++++++++++++++++++++++-
> chardev/char.c | 6 +++++-
> qapi/char.json | 4 ++--
> 3 files changed, 47 insertions(+), 4 deletions(-)
qemu-options.hx needs updating to document the new syntax too
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2019-02-06 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 13:33 [Qemu-devel] [PATCH v3] chardev: Allow for pty path passing Paulo Neves
2019-02-01 19:58 ` no-reply
2019-02-06 15:25 ` Marc-André Lureau
2019-02-06 15:36 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206153631.GS12331@redhat.com \
--to=berrange@redhat.com \
--cc=ptsneves@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).