qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-block@nongnu.org, "Caio Carrara" <ccarrara@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Fam Zheng" <fam@euphon.net>, "Cleber Rosa" <crosa@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 0/1] Introduce a Python module structure
Date: Wed,  6 Feb 2019 11:29:00 -0500	[thread overview]
Message-ID: <20190206162901.19082-1-crosa@redhat.com> (raw)

The amount of Python code that is being reused by a now large number
of different scripts and tests on QEMU urges for a better structure.

This addresses the feedback received on a previous RFC[1], but further
changes that will really benefit from this change were not attempted
here.  Once, the module structure is present, I myself have plans to
send some unittests to "QEMUMachine", to some parts of "qemu.qmp", and
others.

Documentation, lint and style checkers are other possible candidates.

[1] - https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05478.html

---

Git Info:
  - URI: https://github.com/clebergnu/qemu/tree/sent/python_module
  - Remote: https://github.com/clebergnu/qemu
  - Branch: sent/python_module

Travis CI Info:
  - Job: https://travis-ci.org/clebergnu/qemu/builds/489616874

Cleber Rosa (1):
  Introduce a Python module structure

 configure                                  |  1 +
 scripts/qemu.py => python/qemu/__init__.py | 11 ++++++-----
 {scripts/qmp => python/qemu}/qmp.py        |  0
 {scripts => python/qemu}/qtest.py          |  5 +++--
 scripts/device-crash-test                  |  2 ++
 scripts/qmp/__init__.py                    |  0
 scripts/qmp/qemu-ga-client                 |  5 ++++-
 scripts/qmp/qmp-shell                      |  4 +++-
 scripts/render_block_graph.py              |  2 ++
 tests/acceptance/avocado_qemu/__init__.py  |  5 ++---
 tests/acceptance/virtio_version.py         |  2 +-
 tests/migration/guestperf/engine.py        |  7 ++++---
 tests/qemu-iotests/235                     |  2 +-
 tests/qemu-iotests/238                     |  2 +-
 tests/qemu-iotests/iotests.py              |  4 ++--
 tests/vm/basevm.py                         |  2 +-
 16 files changed, 33 insertions(+), 21 deletions(-)
 rename scripts/qemu.py => python/qemu/__init__.py (98%)
 rename {scripts/qmp => python/qemu}/qmp.py (100%)
 rename {scripts => python/qemu}/qtest.py (98%)
 delete mode 100644 scripts/qmp/__init__.py

-- 
2.20.1

             reply	other threads:[~2019-02-06 16:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-06 16:29 Cleber Rosa [this message]
2019-02-06 16:29 ` [Qemu-devel] [PATCH 1/1] Introduce a Python module structure Cleber Rosa
2019-02-11  2:22   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-02-18 19:34   ` [Qemu-devel] " Caio Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190206162901.19082-1-crosa@redhat.com \
    --to=crosa@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=ccarrara@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).