qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] main-loop: Add qemu_idle_add()
Date: Thu, 7 Feb 2019 14:24:26 +0000	[thread overview]
Message-ID: <20190207142426.GK19438@redhat.com> (raw)
In-Reply-To: <2c1d9d03c5b3ee26b116db3438caa3df73dffa46.1549545591.git.berto@igalia.com>

On Thu, Feb 07, 2019 at 03:23:22PM +0200, Alberto Garcia wrote:
> This works like g_idle_add() but allows specifying a different
> GMainContext. It also returns the GSource directly instead of its ID
> number for convenience.
> 
> pty_chr_state() and qio_task_thread_worker() are modified to make use
> of this new function.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  chardev/char-pty.c       | 8 ++------
>  include/qemu/main-loop.h | 8 ++++++++
>  io/task.c                | 7 ++-----
>  util/main-loop.c         | 9 +++++++++
>  4 files changed, 21 insertions(+), 11 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2019-02-07 14:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 13:23 [Qemu-devel] [PATCH 0/3] char-socket: Fix race condition Alberto Garcia
2019-02-07 13:23 ` [Qemu-devel] [PATCH 1/3] main-loop: Don't leak GSources attached to a GMainContext Alberto Garcia
2019-02-07 13:25   ` Alberto Garcia
2019-02-07 14:21   ` Daniel P. Berrangé
2019-02-07 14:23   ` Marc-André Lureau
2019-02-07 14:24     ` Marc-André Lureau
2019-02-07 14:27       ` Alberto Garcia
2019-02-07 14:43         ` Marc-André Lureau
2019-02-07 14:47           ` Alberto Garcia
2019-02-07 13:23 ` [Qemu-devel] [PATCH 2/3] main-loop: Add qemu_idle_add() Alberto Garcia
2019-02-07 14:24   ` Daniel P. Berrangé [this message]
2019-02-07 14:28   ` Marc-André Lureau
2019-02-07 13:23 ` [Qemu-devel] [PATCH 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout() Alberto Garcia
2019-02-07 14:26   ` Daniel P. Berrangé
2019-02-08  8:50     ` Alberto Garcia
2019-02-08  9:34     ` Alberto Garcia
2019-02-08 13:46       ` Paolo Bonzini
2019-02-08 15:01         ` Alberto Garcia
2019-02-08 17:27           ` Paolo Bonzini
2019-02-07 14:46   ` Marc-André Lureau
2019-02-07 15:05     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190207142426.GK19438@redhat.com \
    --to=berrange@redhat.com \
    --cc=berto@igalia.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).