From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v2 03/12] libvhost-user: exit by default on VHOST_USER_NONE
Date: Thu, 7 Feb 2019 17:54:40 +0100 [thread overview]
Message-ID: <20190207165449.6125-4-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20190207165449.6125-1-marcandre.lureau@redhat.com>
Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user
no longer panics on disconnect (rc == 0), and instead silently ignores
an invalid VHOST_USER_NONE message.
Without extra work from the API user, this will simply busy-loop on
HUP events. The obvious thing to do is to exit(0) instead, while
additional or different work can be done by overriding
iface->process_msg().
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
---
contrib/libvhost-user/libvhost-user.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
index 3f14b4138b..fcf5014240 100644
--- a/contrib/libvhost-user/libvhost-user.c
+++ b/contrib/libvhost-user/libvhost-user.c
@@ -1285,7 +1285,8 @@ vu_process_message(VuDev *dev, VhostUserMsg *vmsg)
case VHOST_USER_SET_CONFIG:
return vu_set_config(dev, vmsg);
case VHOST_USER_NONE:
- break;
+ /* if you need processing before exit, override iface->process_msg */
+ exit(0);
case VHOST_USER_POSTCOPY_ADVISE:
return vu_set_postcopy_advise(dev, vmsg);
case VHOST_USER_POSTCOPY_LISTEN:
--
2.20.1.519.g8feddda32c
next prev parent reply other threads:[~2019-02-07 16:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 16:54 [Qemu-devel] [PATCH v2 00/12] vhost-user-backend & vhost-user-input Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 01/12] vhost-user: define conventions for vhost-user backends Marc-André Lureau
2019-02-07 17:42 ` Eric Blake
2019-02-07 18:45 ` Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 02/12] vhost-user: simplify vhost_user_init/vhost_user_cleanup Marc-André Lureau
2019-02-07 16:54 ` Marc-André Lureau [this message]
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 04/12] vhost-user: wrap some read/write with retry handling Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 05/12] Add vhost-user-backend Marc-André Lureau
2019-02-07 17:36 ` Michael S. Tsirkin
2019-02-07 18:29 ` Marc-André Lureau
2019-02-07 19:18 ` Michael S. Tsirkin
2019-02-08 11:15 ` Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 06/12] vhost-user: split vhost_user_read() Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 07/12] vhost-user: add vhost_user_input_get_config() Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 08/12] libvhost-user-glib: export vug_source_new() Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 09/12] libvhost-user: add vu_queue_unpop() Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 10/12] Add vhost-user-input-pci Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 11/12] contrib: add vhost-user-input Marc-André Lureau
2019-02-07 16:54 ` [Qemu-devel] [PATCH v2 12/12] RFC: add explicit can_migrate to vhost_user_backend_dev_init() Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207165449.6125-4-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).