From: Cornelia Huck <cohuck@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Peter Xu <peterx@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"open list:S390" <qemu-s390x@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources
Date: Thu, 7 Feb 2019 18:14:15 +0100 [thread overview]
Message-ID: <20190207181415.07d0d7ae.cohuck@redhat.com> (raw)
In-Reply-To: <20190206174328.9736-4-marcandre.lureau@redhat.com>
On Wed, 6 Feb 2019 18:43:25 +0100
Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
> terminal3270 uses the front-end side of the chardev. It shouldn't
> create sources from backend side context (with backend
> functions).
>
> send_timing_mark_cb calls qemu_chr_fe_write_all() which should be
> thread safe.
>
> This partially reverts changes from commit
> 2c716ba1506769c9be2caa02f0f6d6e7c00f4304.
>
> CC: Peter Xu <peterx@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/char/terminal3270.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
I've verified that 3270 continues to work as before.
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-02-07 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 17:43 [Qemu-devel] [PATCH v2 0/6] chardev: various cleanups and improvements (resend) Marc-André Lureau
2019-02-06 17:43 ` [Qemu-devel] [PATCH v2 1/6] char: update the mux handlers in class callback Marc-André Lureau
2019-02-06 17:43 ` [Qemu-devel] [PATCH v2 2/6] char-fe: set_handlers() needs an associated chardev Marc-André Lureau
2019-02-06 17:43 ` [Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources Marc-André Lureau
2019-02-07 17:14 ` Cornelia Huck [this message]
2019-02-11 7:12 ` Peter Xu
2019-02-11 9:57 ` Marc-André Lureau
2019-02-11 10:27 ` Peter Xu
2019-02-11 10:35 ` Marc-André Lureau
2019-02-06 17:43 ` [Qemu-devel] [PATCH v2 4/6] chardev: add a note about frontend sources and context switch Marc-André Lureau
2019-02-06 17:43 ` [Qemu-devel] [PATCH v2 5/6] char-pty: remove the check for connection on write Marc-André Lureau
2019-02-06 17:43 ` [Qemu-devel] [PATCH v2 6/6] char-pty: remove write_lock usage Marc-André Lureau
2019-02-13 14:35 ` [Qemu-devel] [PATCH v2 0/6] chardev: various cleanups and improvements (resend) Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207181415.07d0d7ae.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).