From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grnFz-0001AC-GZ for qemu-devel@nongnu.org; Thu, 07 Feb 2019 12:14:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grnFy-0006ht-U8 for qemu-devel@nongnu.org; Thu, 07 Feb 2019 12:14:35 -0500 Date: Thu, 7 Feb 2019 18:14:15 +0100 From: Cornelia Huck Message-ID: <20190207181415.07d0d7ae.cohuck@redhat.com> In-Reply-To: <20190206174328.9736-4-marcandre.lureau@redhat.com> References: <20190206174328.9736-1-marcandre.lureau@redhat.com> <20190206174328.9736-4-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: qemu-devel@nongnu.org, Paolo Bonzini , Peter Xu , Halil Pasic , Christian Borntraeger , "open list:S390" On Wed, 6 Feb 2019 18:43:25 +0100 Marc-Andr=C3=A9 Lureau wrote: > terminal3270 uses the front-end side of the chardev. It shouldn't > create sources from backend side context (with backend > functions). >=20 > send_timing_mark_cb calls qemu_chr_fe_write_all() which should be > thread safe. >=20 > This partially reverts changes from commit > 2c716ba1506769c9be2caa02f0f6d6e7c00f4304. >=20 > CC: Peter Xu > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > hw/char/terminal3270.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) I've verified that 3270 continues to work as before. Acked-by: Cornelia Huck