[Qemu-devel] [PATCH 0/4] Trivial fixes for configure and Python scripts

[Qemu-devel] [PATCH 0/4] Trivial fixes for configure and Python scripts

[Cleber Rosa]

This is just a small collection of trivial fixes for configure
and some Python scripts (missing/unused import statements).

Cleber Rosa (4):
  configure: remove handling of "wav" audio driver
  configure: fix qemu-img name
  scripts/render_block_graph.py: add a missing import
  tests/migration/guestperf/engine.py: remove unused import

 configure                           | 6 +-----
 scripts/render_block_graph.py       | 1 +
 tests/migration/guestperf/engine.py | 1 -
 3 files changed, 2 insertions(+), 6 deletions(-)

-- 
2.20.1

[Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver

[Cleber Rosa]

This looks like a leftover that was never implemented.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 configure | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/configure b/configure
index fbd0825488..ff55e2273e 100755
--- a/configure
+++ b/configure
@@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do
       oss_libs="$oss_lib"
     ;;
 
-    wav)
-    # XXX: Probes for CoreAudio, DirectSound
-    ;;
-
     *)
     echo "$audio_possible_drivers" | grep -q "\<$drv\>" || {
         error_exit "Unknown driver '$drv' selected" \
-- 
2.20.1

[Qemu-devel] [PATCH 2/4] configure: fix qemu-img name

[Cleber Rosa]

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index ff55e2273e..c8fc1647fe 100755
--- a/configure
+++ b/configure
@@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   virglrenderer   virgl rendering support
   xfsctl          xfsctl support
   qom-cast-debug  cast debugging support
-  tools           build qemu-io, qemu-nbd and qemu-image tools
+  tools           build qemu-io, qemu-nbd and qemu-img tools
   vxhs            Veritas HyperScale vDisk backend support
   bochs           bochs image format support
   cloop           cloop image format support
-- 
2.20.1

[Qemu-devel] [PATCH 3/4] scripts/render_block_graph.py: add a missing import

[Cleber Rosa]

The handle to QMP may be one of two classes, one implemented locally,
and the other one, which seems to be from "qmp.qmp", but of which an
import is missing.

CC: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 scripts/render_block_graph.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/render_block_graph.py b/scripts/render_block_graph.py
index ed7e581b4f..7686e30761 100755
--- a/scripts/render_block_graph.py
+++ b/scripts/render_block_graph.py
@@ -24,6 +24,7 @@ import subprocess
 import json
 from graphviz import Digraph
 from qemu import MonitorResponseError
+from qmp.qmp import QEMUMonitorProtocol
 
 
 def perm(arr):
-- 
2.20.1

[Qemu-devel] [PATCH 4/4] tests/migration/guestperf/engine.py: remove unused import

[Cleber Rosa]

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/migration/guestperf/engine.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
index 398e3f2706..1daf09c6f2 100644
--- a/tests/migration/guestperf/engine.py
+++ b/tests/migration/guestperf/engine.py
@@ -26,7 +26,6 @@ import time
 
 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', '..', 'scripts'))
 import qemu
-import qmp.qmp
 from guestperf.progress import Progress, ProgressStats
 from guestperf.report import Report
 from guestperf.timings import TimingRecord, Timings
-- 
2.20.1

Re: [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver

[Laurent Vivier]

On 07/02/2019 20:36, Cleber Rosa wrote:
> This looks like a leftover that was never implemented.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  configure | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/configure b/configure
> index fbd0825488..ff55e2273e 100755
> --- a/configure
> +++ b/configure
> @@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do
>        oss_libs="$oss_lib"
>      ;;
>  
> -    wav)
> -    # XXX: Probes for CoreAudio, DirectSound
> -    ;;
> -
>      *)
>      echo "$audio_possible_drivers" | grep -q "\<$drv\>" || {
>          error_exit "Unknown driver '$drv' selected" \
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name

[Laurent Vivier]

On 07/02/2019 20:36, Cleber Rosa wrote:
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index ff55e2273e..c8fc1647fe 100755
> --- a/configure
> +++ b/configure
> @@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>    virglrenderer   virgl rendering support
>    xfsctl          xfsctl support
>    qom-cast-debug  cast debugging support
> -  tools           build qemu-io, qemu-nbd and qemu-image tools
> +  tools           build qemu-io, qemu-nbd and qemu-img tools
>    vxhs            Veritas HyperScale vDisk backend support
>    bochs           bochs image format support
>    cloop           cloop image format support
> 

Fixes: c12d66aac1aa ("configure: add the missing help output for
optional features")

Perhaps the list can be updated with qemu-edid, ivshmem-client and elf2dmp?

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver

[Philippe Mathieu-Daudé]

On 2/7/19 8:36 PM, Cleber Rosa wrote:
> This looks like a leftover that was never implemented.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  configure | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/configure b/configure
> index fbd0825488..ff55e2273e 100755
> --- a/configure
> +++ b/configure
> @@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do
>        oss_libs="$oss_lib"
>      ;;
>  
> -    wav)
> -    # XXX: Probes for CoreAudio, DirectSound
> -    ;;
> -
>      *)
>      echo "$audio_possible_drivers" | grep -q "\<$drv\>" || {
>          error_exit "Unknown driver '$drv' selected" \
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name

[Philippe Mathieu-Daudé]

On 2/7/19 9:11 PM, Laurent Vivier wrote:
> On 07/02/2019 20:36, Cleber Rosa wrote:
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>> ---
>>  configure | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index ff55e2273e..c8fc1647fe 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>>    virglrenderer   virgl rendering support
>>    xfsctl          xfsctl support
>>    qom-cast-debug  cast debugging support
>> -  tools           build qemu-io, qemu-nbd and qemu-image tools
>> +  tools           build qemu-io, qemu-nbd and qemu-img tools
>>    vxhs            Veritas HyperScale vDisk backend support
>>    bochs           bochs image format support
>>    cloop           cloop image format support
>>
> 
> Fixes: c12d66aac1aa ("configure: add the missing help output for
> optional features")
> 
> Perhaps the list can be updated with qemu-edid, ivshmem-client and elf2dmp?

Good idea! Eventually the trivial@ maintainer is willing to fulfil your
request if he takes this patch :D

> Reviewed-by: Laurent Vivier <laurent@vivier.eu>

As it or with Laurent's suggestion:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/4] configure: remove handling of "wav" audio driver

[Laurent Vivier]

On 07/02/2019 20:36, Cleber Rosa wrote:
> This looks like a leftover that was never implemented.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  configure | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/configure b/configure
> index fbd0825488..ff55e2273e 100755
> --- a/configure
> +++ b/configure
> @@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do
>        oss_libs="$oss_lib"
>      ;;
>  
> -    wav)
> -    # XXX: Probes for CoreAudio, DirectSound
> -    ;;
> -
>      *)
>      echo "$audio_possible_drivers" | grep -q "\<$drv\>" || {
>          error_exit "Unknown driver '$drv' selected" \
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] configure: fix qemu-img name

[Laurent Vivier]

On 07/02/2019 20:36, Cleber Rosa wrote:
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index ff55e2273e..c8fc1647fe 100755
> --- a/configure
> +++ b/configure
> @@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>    virglrenderer   virgl rendering support
>    xfsctl          xfsctl support
>    qom-cast-debug  cast debugging support
> -  tools           build qemu-io, qemu-nbd and qemu-image tools
> +  tools           build qemu-io, qemu-nbd and qemu-img tools
>    vxhs            Veritas HyperScale vDisk backend support
>    bochs           bochs image format support
>    cloop           cloop image format support
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] Trivial fixes for configure and Python scripts

[Laurent Vivier]

On 07/02/2019 20:36, Cleber Rosa wrote:
> This is just a small collection of trivial fixes for configure
> and some Python scripts (missing/unused import statements).
> 
> Cleber Rosa (4):
>   configure: remove handling of "wav" audio driver
>   configure: fix qemu-img name
>   scripts/render_block_graph.py: add a missing import
>   tests/migration/guestperf/engine.py: remove unused import
> 
>  configure                           | 6 +-----
>  scripts/render_block_graph.py       | 1 +
>  tests/migration/guestperf/engine.py | 1 -
>  3 files changed, 2 insertions(+), 6 deletions(-)
> 

I've applied to my trivial-patches branchi patches 1 and 2, but not 3
and 4 as I don't know python and no one has reviewed them.

Thanks,
Laurent