From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH v3 07/10] iotests.py: Filter filename in any string value
Date: Sun, 10 Feb 2019 15:57:33 +0100 [thread overview]
Message-ID: <20190210145736.1486-8-mreitz@redhat.com> (raw)
In-Reply-To: <20190210145736.1486-1-mreitz@redhat.com>
filter_qmp_testfiles() currently filters the filename only for specific
keys. However, there are more keys that take filenames (such as
block-commit's @top and @base, or ssh's @path), and it does not make
sense to list them all here. "$TEST_DIR/$PID-" should have enough
entropy not to appear anywhere randomly.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
tests/qemu-iotests/iotests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 52fc77563c..cba91a9927 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -289,7 +289,7 @@ def filter_testfiles(msg):
def filter_qmp_testfiles(qmsg):
def _filter(key, value):
- if key == 'filename' or key == 'backing-file':
+ if is_str(value):
return filter_testfiles(value)
return value
return filter_qmp(qmsg, _filter)
--
2.20.1
next prev parent reply other threads:[~2019-02-10 14:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 14:57 [Qemu-devel] [PATCH v3 00/10] iotests: Fix some issues Max Reitz
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 01/10] iotests: Re-add filename filters Max Reitz
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 02/10] iotests: Fix 237 for Python 2.x Max Reitz
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 03/10] iotests: Remove superfluous rm from 232 Max Reitz
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 04/10] iotests: Fix 232 for LUKS Max Reitz
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 05/10] iotests: Fix 207 to use QMP filters for qmp_log Max Reitz
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 06/10] iotests.py: Add is_str() Max Reitz
2019-02-10 14:57 ` Max Reitz [this message]
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 08/10] iotests: Filter SSH paths Max Reitz
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 09/10] iotests: Let 045 be run concurrently Max Reitz
2019-02-10 14:57 ` [Qemu-devel] [PATCH v3 10/10] iotests.py: s/_/-/g on keys in qmp_log() Max Reitz
2019-02-10 14:59 ` Max Reitz
2019-02-13 17:30 ` [Qemu-devel] [PATCH v3 00/10] iotests: Fix some issues Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190210145736.1486-8-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).