From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev
Date: Mon, 11 Feb 2019 11:53:05 +0800 [thread overview]
Message-ID: <20190211035305.GE18083@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190208142347.214815-1-sgarzare@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
On Fri, Feb 08, 2019 at 03:23:47PM +0100, Stefano Garzarella wrote:
> In several part we still using req->dev or VIRTIO_DEVICE(req->dev)
> when we have already defined s and vdev pointers:
> VirtIOBlock *s = req->dev;
> VirtIODevice *vdev = VIRTIO_DEVICE(s);
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> hw/block/virtio-blk.c | 22 +++++++++-------------
> 1 file changed, 9 insertions(+), 13 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2019-02-11 3:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 14:23 [Qemu-devel] [PATCH] virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev Stefano Garzarella
2019-02-08 14:34 ` Liam Merwick
2019-02-11 3:53 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211035305.GE18083@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).