* [Qemu-devel] virtio-blk io bar size changed
@ 2019-02-11 16:58 Dr. David Alan Gilbert
2019-02-11 17:22 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2019-02-11 16:58 UTC (permalink / raw)
To: qemu-devel, changpeng.liu, mst, stefanha; +Cc: ldoktor
Hi,
Lukáš reported that there's a migration breakage between 3.1 and
current head with virtio-blk; it looks like the io bar changes from 64
to 128 bytes and my bisect suggests it's:
commit caa1ee43131c060347b32893abd41fe4865eaa2e (HEAD, refs/bisect/bad)
Author: Changpeng Liu <changpeng.liu@intel.com>
Date: Wed Jan 16 13:19:30 2019 +0800
vhost-user-blk: add discard/write zeroes features support
How do we fix that?
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] virtio-blk io bar size changed
2019-02-11 16:58 [Qemu-devel] virtio-blk io bar size changed Dr. David Alan Gilbert
@ 2019-02-11 17:22 ` Michael S. Tsirkin
2019-02-12 1:59 ` Liu, Changpeng
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2019-02-11 17:22 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: qemu-devel, changpeng.liu, stefanha, ldoktor
On Mon, Feb 11, 2019 at 04:58:19PM +0000, Dr. David Alan Gilbert wrote:
> Hi,
> Lukáš reported that there's a migration breakage between 3.1 and
> current head with virtio-blk; it looks like the io bar changes from 64
> to 128 bytes and my bisect suggests it's:
>
> commit caa1ee43131c060347b32893abd41fe4865eaa2e (HEAD, refs/bisect/bad)
> Author: Changpeng Liu <changpeng.liu@intel.com>
> Date: Wed Jan 16 13:19:30 2019 +0800
>
> vhost-user-blk: add discard/write zeroes features support
>
>
> How do we fix that?
>
> Dave
Quickly :)
See the logic around virtio_net_set_config_size
and static VirtIOFeature feature_sizes - we need to
add something similar to virtio blk now.
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] virtio-blk io bar size changed
2019-02-11 17:22 ` Michael S. Tsirkin
@ 2019-02-12 1:59 ` Liu, Changpeng
2019-02-12 3:21 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Liu, Changpeng @ 2019-02-12 1:59 UTC (permalink / raw)
To: Michael S. Tsirkin, Dr. David Alan Gilbert
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, ldoktor@redhat.com
> -----Original Message-----
> From: Michael S. Tsirkin [mailto:mst@redhat.com]
> Sent: Tuesday, February 12, 2019 1:23 AM
> To: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: qemu-devel@nongnu.org; Liu, Changpeng <changpeng.liu@intel.com>;
> stefanha@redhat.com; ldoktor@redhat.com
> Subject: Re: virtio-blk io bar size changed
>
> On Mon, Feb 11, 2019 at 04:58:19PM +0000, Dr. David Alan Gilbert wrote:
> > Hi,
> > Lukáš reported that there's a migration breakage between 3.1 and
> > current head with virtio-blk; it looks like the io bar changes from 64
> > to 128 bytes and my bisect suggests it's:
> >
> > commit caa1ee43131c060347b32893abd41fe4865eaa2e (HEAD, refs/bisect/bad)
> > Author: Changpeng Liu <changpeng.liu@intel.com>
> > Date: Wed Jan 16 13:19:30 2019 +0800
> >
> > vhost-user-blk: add discard/write zeroes features support
> >
> >
> > How do we fix that?
> >
> > Dave
>
> Quickly :)
>
> See the logic around virtio_net_set_config_size
> and static VirtIOFeature feature_sizes - we need to
> add something similar to virtio blk now.
Correct, after this commit the BAR config size is changed, I will submit a patch to fix this.
>
>
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] virtio-blk io bar size changed
2019-02-12 1:59 ` Liu, Changpeng
@ 2019-02-12 3:21 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2019-02-12 3:21 UTC (permalink / raw)
To: Liu, Changpeng
Cc: Dr. David Alan Gilbert, qemu-devel@nongnu.org,
stefanha@redhat.com, ldoktor@redhat.com
On Tue, Feb 12, 2019 at 01:59:38AM +0000, Liu, Changpeng wrote:
>
>
> > -----Original Message-----
> > From: Michael S. Tsirkin [mailto:mst@redhat.com]
> > Sent: Tuesday, February 12, 2019 1:23 AM
> > To: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > Cc: qemu-devel@nongnu.org; Liu, Changpeng <changpeng.liu@intel.com>;
> > stefanha@redhat.com; ldoktor@redhat.com
> > Subject: Re: virtio-blk io bar size changed
> >
> > On Mon, Feb 11, 2019 at 04:58:19PM +0000, Dr. David Alan Gilbert wrote:
> > > Hi,
> > > Lukáš reported that there's a migration breakage between 3.1 and
> > > current head with virtio-blk; it looks like the io bar changes from 64
> > > to 128 bytes and my bisect suggests it's:
> > >
> > > commit caa1ee43131c060347b32893abd41fe4865eaa2e (HEAD, refs/bisect/bad)
> > > Author: Changpeng Liu <changpeng.liu@intel.com>
> > > Date: Wed Jan 16 13:19:30 2019 +0800
> > >
> > > vhost-user-blk: add discard/write zeroes features support
> > >
> > >
> > > How do we fix that?
> > >
> > > Dave
> >
> > Quickly :)
> >
> > See the logic around virtio_net_set_config_size
> > and static VirtIOFeature feature_sizes - we need to
> > add something similar to virtio blk now.
> Correct, after this commit the BAR config size is changed, I will submit a patch to fix this.
Thanks!
> >
> >
> > > --
> > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-12 3:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-11 16:58 [Qemu-devel] virtio-blk io bar size changed Dr. David Alan Gilbert
2019-02-11 17:22 ` Michael S. Tsirkin
2019-02-12 1:59 ` Liu, Changpeng
2019-02-12 3:21 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).