qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PULL 13/18] tests/vm: call make check directly for netbsd/freebsd/ubuntu.i386
Date: Mon, 11 Feb 2019 13:05:02 +0000	[thread overview]
Message-ID: <20190211130507.8710-14-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190211130507.8710-1-alex.bennee@linaro.org>

The "make check" target calls check-qtest which has the appropriate
system binaries as dependencies so we shouldn't need to do two steps
of make invocation. Doing it in two steps was a hangover from when our
make check couldn't run tests in parallel.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

diff --git a/tests/vm/freebsd b/tests/vm/freebsd
index 19a3729172..a85c866c30 100755
--- a/tests/vm/freebsd
+++ b/tests/vm/freebsd
@@ -25,7 +25,6 @@ class FreeBSDVM(basevm.BaseVM):
         cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
         tar -xf /dev/vtbd1;
         ./configure {configure_opts};
-        gmake --output-sync -j{jobs} {verbose};
         gmake --output-sync -j{jobs} check {verbose};
     """
 
diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index fac6a7ce51..edea113bb5 100755
--- a/tests/vm/netbsd
+++ b/tests/vm/netbsd
@@ -25,7 +25,6 @@ class NetBSDVM(basevm.BaseVM):
         cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
         tar -xf /dev/rld1a;
         ./configure --python=python2.7 {configure_opts};
-        gmake --output-sync -j{jobs} {verbose};
         gmake --output-sync -j{jobs} check {verbose};
     """
 
diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
index 1b7e1ab8f0..252e514859 100755
--- a/tests/vm/ubuntu.i386
+++ b/tests/vm/ubuntu.i386
@@ -26,7 +26,6 @@ class UbuntuX86VM(basevm.BaseVM):
         sudo chmod a+r /dev/vdb;
         tar -xf /dev/vdb;
         ./configure {configure_opts};
-        make --output-sync -j{jobs};
         make --output-sync check -j{jobs} {verbose};
     """
 
-- 
2.20.1

  parent reply	other threads:[~2019-02-11 13:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 13:04 [Qemu-devel] [PULL 00/18] testing updates: travis/cirrus/vm-test/binfmt Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 01/18] .cirrus.yml: basic compile and test for FreeBSD Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 02/18] .travis.yml: stop requesting libffi & gettext from homebrew Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 03/18] .travis.yml: separate tools and docs into another entry Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 04/18] .travis.yml: fold --disable-tcg into alternate coroutine builds Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 05/18] MAINTAINERS: Add an entry for scripts/archive-source.sh Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 06/18] archive-source.sh: Clone the submodules locally Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 07/18] docker: add debian-buster-arm64-cross Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 08/18] tests: make docker.py update use configured binfmt path Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 09/18] tests: make docker.py check for persistent configs Alex Bennée
2019-02-11 13:04 ` [Qemu-devel] [PULL 10/18] tests: docker.py be even smarter with persistent binfmt_misc Alex Bennée
2019-02-11 13:05 ` [Qemu-devel] [PULL 11/18] tests: PEP8 cleanup of docker.py, mostly white space Alex Bennée
2019-02-11 13:05 ` [Qemu-devel] [PULL 12/18] tests/vm: move images to $HOME/.cache/qemu-vm/images Alex Bennée
2019-02-11 13:05 ` Alex Bennée [this message]
2019-02-11 13:05 ` [Qemu-devel] [PULL 14/18] tests/vm: add --build-target option Alex Bennée
2019-02-11 13:05 ` [Qemu-devel] [PULL 15/18] tests/vm: expose BUILD_TARGET, TARGET_LIST and EXTRA_CONFIGURE_OPTS Alex Bennée
2019-02-11 13:05 ` [Qemu-devel] [PULL 16/18] scripts/qemu.py: allow arches use KVM for their 32bit cousins Alex Bennée
2019-02-11 13:05 ` [Qemu-devel] [PULL 17/18] docs/devel/testing: Add -a option to usermod command on docker setup Alex Bennée
2019-02-11 13:05 ` [Qemu-devel] [PULL 18/18] tests/vm: Be verbose while extracting compressed images Alex Bennée
2019-02-11 13:14   ` Philippe Mathieu-Daudé
2019-02-11 16:08 ` [Qemu-devel] [PULL 00/18] testing updates: travis/cirrus/vm-test/binfmt Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211130507.8710-14-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).