From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtCnk-00006x-Lf for qemu-devel@nongnu.org; Mon, 11 Feb 2019 09:43:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtCnj-0006wo-8B for qemu-devel@nongnu.org; Mon, 11 Feb 2019 09:43:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18925) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gtCni-0006vW-Mv for qemu-devel@nongnu.org; Mon, 11 Feb 2019 09:43:14 -0500 Date: Mon, 11 Feb 2019 15:43:07 +0100 From: Igor Mammedov Message-ID: <20190211154307.203f8d35@redhat.com> In-Reply-To: <20190211064629.20186-1-richardw.yang@linux.intel.com> References: <20190211064629.20186-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] pc-dimm: use same mechanism for [get|set]_addr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Yang Cc: qemu-devel@nongnu.org, mst@redhat.com On Mon, 11 Feb 2019 14:46:29 +0800 Wei Yang wrote: > [get|set]_addr are two counterpart to access PCDIMMDevice.addr. > > Since we have already set up a property PC_DIMM_ADDR_PROP for this > field and use this mechanism in set_addr, it would be more proper to use > the same mechanism in get_addr. > > This patch uses object_property_get_uint() to replace the direct memory > access to make [get|set]_addr with the same mechanism. > > Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov > > --- > v2: replace NULL with error_abort to handle error properly > --- > hw/mem/pc-dimm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c > index 0c9b9e8292..152400b1fc 100644 > --- a/hw/mem/pc-dimm.c > +++ b/hw/mem/pc-dimm.c > @@ -204,9 +204,7 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp) > > static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md) > { > - const PCDIMMDevice *dimm = PC_DIMM(md); > - > - return dimm->addr; > + return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP, &error_abort); > } > > static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr,