From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtE4Y-0003LM-TQ for qemu-devel@nongnu.org; Mon, 11 Feb 2019 11:04:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtE4W-0004N7-CU for qemu-devel@nongnu.org; Mon, 11 Feb 2019 11:04:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46706) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gtE4U-0004CI-Cg for qemu-devel@nongnu.org; Mon, 11 Feb 2019 11:04:40 -0500 Date: Mon, 11 Feb 2019 16:03:57 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20190211160357.GK2627@work-vm> References: <20190204130958.18904-1-yury-kotov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204130958.18904-1-yury-kotov@yandex-team.ru> Subject: Re: [Qemu-devel] [PATCH v2 0/5] Add ignore-external migration capability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yury Kotov , qemu-devel@lists.ewheeler.net, jiangshanlai@gmail.com, peter.maydell@linaro.org Cc: qemu-devel@nongnu.org, Eduardo Habkost , Igor Mammedov , Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Juan Quintela , Eric Blake , Markus Armbruster , Thomas Huth , Laurent Vivier , wrfsh@yandex-team.ru * Yury Kotov (yury-kotov@yandex-team.ru) wrote: > Hi, > > The series adds a migration capability, which allows to skip shared RAM blocks > during the migration. It's useful for fast local migration. E.g. to update QEMU > for the running guests. > > Usage example: > 1. Start source VM: > qemu-system-x86 \ > -m 4G \ > -object memory-backend-file,id=mem0,size=4G,share=on,mem-path=/dev/shm/mem0 \ > -numa node,memdev=mem0 \ > -qmp unix:/tmp/qemu-qmp-1.sock,server,nowait \ > > 2. Start target VM: > qemu-system-x86 \ > -m 4G \ > -object memory-backend-file,id=mem0,size=4G,share=on,mem-path=/dev/shm/mem0 \ > -numa node,memdev=mem0 \ > -qmp unix:/tmp/qemu-qmp-2.sock,server,nowait \ > -incoming defer > > 3. Enable ignore-external capability on both VMs: > { "execute": "migrate-set-capabilities" , "arguments": > { "capabilities": [ { "capability": "x-ignore-external", "state": true } ] } } > > 4. Start migration. > > Another use case I keep in mind is to migrate to file. Usage is very similar. Hi, I've cc'd in Eric, Lai and Peter, all who were asking for something similar last year; can you all confirm this patch does what you need or can work with what you needed to do? Dave > V1 to V2: > * Keep migration stream compatibility > * Reuse the existing code to ignore unwanted RAMBlocks > * Add capability validation feature > * ignore-external -> ignore-shared > > Regards, > Yury > > Yury Kotov (5): > exec: Change RAMBlockIterFunc definition > migration: Move qemu_ram_foreach_migratable_block to migration code > migration: Introduce ignore-shared capability > tests/migration-test: Add a test for ignore-shared capability > migration: Add capabilities validation > > exec.c | 38 ++++++------- > include/exec/cpu-common.h | 7 +-- > migration/migration.c | 9 ++++ > migration/migration.h | 11 +++- > migration/postcopy-ram.c | 48 +++++++++-------- > migration/ram.c | 86 ++++++++++++++++++++++++++---- > migration/rdma.c | 9 ++-- > migration/savevm.c | 101 +++++++++++++++++++++++++++++++++++ > qapi/migration.json | 5 +- > stubs/ram-block.c | 15 ++++++ > tests/migration-test.c | 109 +++++++++++++++++++++++++++++++------- > util/vfio-helpers.c | 6 +-- > 12 files changed, 361 insertions(+), 83 deletions(-) > > -- > 2.20.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK