qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Liu, Changpeng" <changpeng.liu@intel.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"ldoktor@redhat.com" <ldoktor@redhat.com>
Subject: Re: [Qemu-devel] virtio-blk io bar size changed
Date: Mon, 11 Feb 2019 22:21:10 -0500	[thread overview]
Message-ID: <20190211222053-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <FF7FC980937D6342B9D289F5F3C7C2625B7B4E39@SHSMSX103.ccr.corp.intel.com>

On Tue, Feb 12, 2019 at 01:59:38AM +0000, Liu, Changpeng wrote:
> 
> 
> > -----Original Message-----
> > From: Michael S. Tsirkin [mailto:mst@redhat.com]
> > Sent: Tuesday, February 12, 2019 1:23 AM
> > To: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > Cc: qemu-devel@nongnu.org; Liu, Changpeng <changpeng.liu@intel.com>;
> > stefanha@redhat.com; ldoktor@redhat.com
> > Subject: Re: virtio-blk io bar size changed
> > 
> > On Mon, Feb 11, 2019 at 04:58:19PM +0000, Dr. David Alan Gilbert wrote:
> > > Hi,
> > >   Lukáš reported that there's a migration breakage between 3.1 and
> > > current head with virtio-blk;   it looks like the io bar changes from 64
> > > to 128 bytes and my bisect suggests it's:
> > >
> > > commit caa1ee43131c060347b32893abd41fe4865eaa2e (HEAD, refs/bisect/bad)
> > > Author: Changpeng Liu <changpeng.liu@intel.com>
> > > Date:   Wed Jan 16 13:19:30 2019 +0800
> > >
> > >     vhost-user-blk: add discard/write zeroes features support
> > >
> > >
> > > How do we fix that?
> > >
> > > Dave
> > 
> > Quickly :)
> > 
> > See the logic around virtio_net_set_config_size
> > and static VirtIOFeature feature_sizes - we need to
> > add something similar to virtio blk now.
> Correct, after this commit the BAR config size is changed, I will submit a patch to fix this.

Thanks!

> > 
> > 
> > > --
> > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

      reply	other threads:[~2019-02-12  3:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 16:58 [Qemu-devel] virtio-blk io bar size changed Dr. David Alan Gilbert
2019-02-11 17:22 ` Michael S. Tsirkin
2019-02-12  1:59   ` Liu, Changpeng
2019-02-12  3:21     ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211222053-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=changpeng.liu@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).