From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtQ8y-0002fG-7w for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:58:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtQ8m-0001qO-He for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:57:56 -0500 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:35262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtQ8m-0001jw-0s for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:57:52 -0500 Received: by mail-pg1-x52c.google.com with SMTP id s198so676411pgs.2 for ; Mon, 11 Feb 2019 20:57:48 -0800 (PST) From: Richard Henderson Date: Mon, 11 Feb 2019 20:57:16 -0800 Message-Id: <20190212045721.28041-20-richard.henderson@linaro.org> In-Reply-To: <20190212045721.28041-1-richard.henderson@linaro.org> References: <20190212045721.28041-1-richard.henderson@linaro.org> Subject: [Qemu-devel] [PULL 19/24] target/hppa: Merge translate_one into hppa_tr_translate_insn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Now that the implementation is entirely within the generated decode function, eliminate the wrapper. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index ecec5c42d1..6836fb6245 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3982,13 +3982,6 @@ static bool trans_fmpyfadd_d(DisasContext *ctx, arg_fmpyfadd_d *a) return nullify_end(ctx); } -static void translate_one(DisasContext *ctx, uint32_t insn) -{ - if (!decode(ctx, insn)) { - gen_illegal(ctx); - } -} - static void hppa_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs) { DisasContext *ctx = container_of(dcbase, DisasContext, base); @@ -4094,7 +4087,9 @@ static void hppa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) ret = DISAS_NEXT; } else { ctx->insn = insn; - translate_one(ctx, insn); + if (!decode(ctx, insn)) { + gen_illegal(ctx); + } ret = ctx->base.is_jmp; assert(ctx->null_lab == NULL); } -- 2.17.2