From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 06/13] block: Handle child references in bdrv_reopen_queue()
Date: Tue, 12 Feb 2019 17:55:22 +0100 [thread overview]
Message-ID: <20190212165522.GH5283@localhost.localdomain> (raw)
In-Reply-To: <20190212162806.GF5283@localhost.localdomain>
Am 12.02.2019 um 17:28 hat Kevin Wolf geschrieben:
> > - child_key_dot = g_strdup_printf("%s.", child->name);
> > - qdict_extract_subqdict(explicit_options, NULL, child_key_dot);
> > - qdict_extract_subqdict(options, &new_child_options, child_key_dot);
> > - g_free(child_key_dot);
> > + /* Check if the options contain a child reference */
> > + if (qdict_haskey(options, child->name)) {
> > + const char *childref = qdict_get_try_str(options, child->name);
> > + /*
> > + * The current child must not be reopened if the child
> > + * reference does not point to it.
> > + */
> > + if (g_strcmp0(childref, child->bs->node_name)) {
>
> This is where we would break the inheritance relationship.
Oops, correcting myself: It's not. We may only do that in the commit
stage, of course.
Kevin
next prev parent reply other threads:[~2019-02-12 16:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:33 [Qemu-devel] [PATCH 00/13] Add a 'x-blockdev-reopen' QMP command Alberto Garcia
2019-01-17 15:33 ` [Qemu-devel] [PATCH 01/13] block: Allow freezing BdrvChild links Alberto Garcia
2019-02-12 14:47 ` Kevin Wolf
2019-02-14 14:13 ` Alberto Garcia
2019-02-14 15:52 ` Kevin Wolf
2019-02-18 13:35 ` Alberto Garcia
2019-01-17 15:33 ` [Qemu-devel] [PATCH 02/13] block: Freeze the backing chain for the duration of the commit job Alberto Garcia
2019-02-12 14:54 ` Kevin Wolf
2019-02-14 15:21 ` Alberto Garcia
2019-02-14 15:45 ` Kevin Wolf
2019-01-17 15:33 ` [Qemu-devel] [PATCH 03/13] block: Freeze the backing chain for the duration of the mirror job Alberto Garcia
2019-01-17 15:33 ` [Qemu-devel] [PATCH 04/13] block: Freeze the backing chain for the duration of the stream job Alberto Garcia
2019-02-12 15:15 ` Kevin Wolf
2019-02-12 16:06 ` Alberto Garcia
2019-01-17 15:33 ` [Qemu-devel] [PATCH 05/13] block: Add 'keep_old_opts' parameter to bdrv_reopen_queue() Alberto Garcia
2019-01-17 15:33 ` [Qemu-devel] [PATCH 06/13] block: Handle child references in bdrv_reopen_queue() Alberto Garcia
2019-02-12 16:28 ` Kevin Wolf
2019-02-12 16:55 ` Kevin Wolf [this message]
2019-02-19 16:00 ` Alberto Garcia
2019-01-17 15:33 ` [Qemu-devel] [PATCH 07/13] block: Allow omitting the 'backing' option in certain cases Alberto Garcia
2019-02-12 16:38 ` Kevin Wolf
2019-01-17 15:33 ` [Qemu-devel] [PATCH 08/13] block: Allow changing the backing file on reopen Alberto Garcia
2019-02-12 17:27 ` Kevin Wolf
2019-02-21 14:46 ` Alberto Garcia
2019-02-21 14:53 ` Alberto Garcia
2019-01-17 15:34 ` [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver Alberto Garcia
2019-02-12 18:02 ` Kevin Wolf
2019-03-01 12:12 ` Alberto Garcia
2019-03-01 12:36 ` Kevin Wolf
2019-03-01 12:42 ` Alberto Garcia
2019-03-01 12:56 ` Kevin Wolf
2019-03-01 13:05 ` Alberto Garcia
2019-03-01 14:18 ` Kevin Wolf
2019-03-01 14:37 ` Alberto Garcia
2019-01-17 15:34 ` [Qemu-devel] [PATCH 10/13] block: Add bdrv_reset_options_allowed() Alberto Garcia
2019-01-17 15:34 ` [Qemu-devel] [PATCH 11/13] block: Remove the AioContext parameter from bdrv_reopen_multiple() Alberto Garcia
2019-01-17 15:34 ` [Qemu-devel] [PATCH 12/13] block: Add an 'x-blockdev-reopen' QMP command Alberto Garcia
2019-01-17 15:34 ` [Qemu-devel] [PATCH 13/13] qemu-iotests: Test the x-blockdev-reopen " Alberto Garcia
2019-01-17 15:50 ` [Qemu-devel] [PATCH 00/13] Add a 'x-blockdev-reopen' " Eric Blake
2019-01-17 16:05 ` Alberto Garcia
2019-01-22 8:15 ` Vladimir Sementsov-Ogievskiy
2019-01-23 15:56 ` Alberto Garcia
2019-01-31 15:11 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212165522.GH5283@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).