qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>
Subject: [Qemu-devel] [PATCH v3 01/12] block: Mark commit and mirror as filter drivers
Date: Wed, 13 Feb 2019 23:53:00 +0100	[thread overview]
Message-ID: <20190213225311.17876-2-mreitz@redhat.com> (raw)
In-Reply-To: <20190213225311.17876-1-mreitz@redhat.com>

The commit and mirror block nodes are filters, so they should be marked
as such.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
 block/commit.c | 2 ++
 block/mirror.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/block/commit.c b/block/commit.c
index 2b876bf6e9..87d0b208ea 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -254,6 +254,8 @@ static BlockDriver bdrv_commit_top = {
     .bdrv_co_block_status       = bdrv_co_block_status_from_backing,
     .bdrv_refresh_filename      = bdrv_commit_top_refresh_filename,
     .bdrv_child_perm            = bdrv_commit_top_child_perm,
+
+    .is_filter                  = true,
 };
 
 void commit_start(const char *job_id, BlockDriverState *bs,
diff --git a/block/mirror.c b/block/mirror.c
index 726d3c27fb..c7ca8078d1 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1469,6 +1469,8 @@ static BlockDriver bdrv_mirror_top = {
     .bdrv_co_block_status       = bdrv_co_block_status_from_backing,
     .bdrv_refresh_filename      = bdrv_mirror_top_refresh_filename,
     .bdrv_child_perm            = bdrv_mirror_top_child_perm,
+
+    .is_filter                  = true,
 };
 
 static void mirror_start_job(const char *job_id, BlockDriverState *bs,
-- 
2.20.1

  reply	other threads:[~2019-02-13 22:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 22:52 [Qemu-devel] [PATCH v3 00/12] block: Deal with filters Max Reitz
2019-02-13 22:53 ` Max Reitz [this message]
2019-02-13 23:24   ` [Qemu-devel] [PATCH v3 01/12] block: Mark commit and mirror as filter drivers Eric Blake
2019-02-15 17:38     ` Max Reitz
     [not found]   ` <20190319131600.GE6569@dhcp-200-226.str.redhat.com>
2019-04-01 17:22     ` Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 02/12] blockdev: Check @replaces in blockdev_mirror_common Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 03/12] block: Filtered children access functions Max Reitz
2019-02-14  2:25   ` Eric Blake
2019-02-15 16:45     ` Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 04/12] block: Storage child access function Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 05/12] block: Inline bdrv_co_block_status_from_*() Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 06/12] block: Fix check_to_replace_node() Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 07/12] iotests: Add tests for mirror @replaces loops Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 08/12] block: Leave BDS.backing_file constant Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 09/12] iotests: Add filter commit test cases Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 10/12] iotests: Add filter mirror " Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 11/12] iotests: Add test for commit in sub directory Max Reitz
2019-02-13 22:53 ` [Qemu-devel] [PATCH v3 12/12] iotests: Test committing to overridden backing Max Reitz
2019-04-01 20:18 ` [Qemu-devel] [PATCH v3 00/12] block: Deal with filters Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213225311.17876-2-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).