From: Stefan Hajnoczi <stefanha@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Zhang Yi <yi.z.zhang@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] hostmem-file: reject invalid pmem file sizes
Date: Thu, 14 Feb 2019 16:15:58 +0800 [thread overview]
Message-ID: <20190214081558.GA7652@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190214041915.GA10412@richard>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Thu, Feb 14, 2019 at 12:19:15PM +0800, Wei Yang wrote:
> On Thu, Feb 14, 2019 at 11:10:04AM +0800, Stefan Hajnoczi wrote:
> >diff --git a/util/oslib-win32.c b/util/oslib-win32.c
> >index b4c17f5dfa..bd633afab6 100644
> >--- a/util/oslib-win32.c
> >+++ b/util/oslib-win32.c
> >@@ -560,6 +560,11 @@ void os_mem_prealloc(int fd, char *area, size_t memory, int smp_cpus,
> > }
> > }
> >
> >+uint64_t qemu_get_pmem_size(const char *filename, Error **errp)
> >+{
> >+ error_setg(errp, "pmem support not available");
> >+ return 0;
> >+}
>
> After the cleanup from Igor, qemu_get_pmem_size() would be invoked only on
> POSIX system.
>
> Is it still necessary to define this on win32?
Either way is possible. I'd like to leave it like this unless there are
strong feelings against this.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2019-02-14 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 3:10 [Qemu-devel] [PATCH v3 0/2] hostmem-file: reject invalid pmem file sizes Stefan Hajnoczi
2019-02-14 3:10 ` [Qemu-devel] [PATCH v3 1/2] hostmem: simplify ifdef-s in file_backend_memory_alloc() Stefan Hajnoczi
2019-02-14 7:26 ` Wei Yang
2019-02-14 8:16 ` Stefan Hajnoczi
2019-03-01 10:40 ` Igor Mammedov
2019-03-01 16:47 ` Stefan Hajnoczi
2019-03-06 10:23 ` Laurent Vivier
2019-02-14 3:10 ` [Qemu-devel] [PATCH v3 2/2] hostmem-file: reject invalid pmem file sizes Stefan Hajnoczi
2019-02-14 4:19 ` Wei Yang
2019-02-14 8:15 ` Stefan Hajnoczi [this message]
2019-02-14 8:20 ` Wei Yang
2019-02-14 11:01 ` Igor Mammedov
2019-03-08 17:53 ` Eduardo Habkost
2019-02-14 8:50 ` [Qemu-devel] [PATCH v3 0/2] " Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214081558.GA7652@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
--cc=yi.z.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).