From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <laurent@vivier.eu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
kvm@vger.kernel.org, libvir-list@redhat.com,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-trivial@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Kamil Rytarowski" <kamil@netbsd.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PULL 09/14] HMP: Prepend errors with 'Error:'
Date: Thu, 14 Feb 2019 11:47:12 +0100 [thread overview]
Message-ID: <20190214104717.3543-10-laurent@vivier.eu> (raw)
In-Reply-To: <20190214104717.3543-1-laurent@vivier.eu>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Always make error messages start with 'Error:' as a fallback
to make sure that anything parsing them can tell it failed.
Note: Some places don't use hmp_handle_error
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20190212134758.10514-3-dgilbert@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index b2a2b1f84e33..4d14718fea4a 100644
--- a/hmp.c
+++ b/hmp.c
@@ -62,7 +62,7 @@ static void hmp_handle_error(Monitor *mon, Error **errp)
{
assert(errp);
if (*errp) {
- error_report_err(*errp);
+ error_reportf_err(*errp, "Error: ");
}
}
--
2.20.1
next prev parent reply other threads:[~2019-02-14 10:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 10:47 [Qemu-devel] [PULL 00/14] Trivial branch patches Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 01/14] qapi: Fix qcow2 encryption doc typo Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 02/14] qemu-deprecated: Remove -virtioconsole and -no-frame for good Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 03/14] qemu-options: Remove deprecated option -clock Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 04/14] configure: remove handling of "wav" audio driver Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 05/14] configure: fix qemu-img name Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 06/14] configure: Add HAX support in NetBSD Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 07/14] configure: Make -Waddress-of-packed-member warnings be errors Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 08/14] pckbd: Convert DPRINTF->trace Laurent Vivier
2019-02-14 10:47 ` Laurent Vivier [this message]
2019-02-14 10:47 ` [Qemu-devel] [PULL 10/14] kvm: Add kvm_set_ioeventfd* traces Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 11/14] wavcapture: Convert to error_report Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 12/14] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 13/14] hw/sparc64: Explicitly set default_display = "std" Laurent Vivier
2019-02-14 10:47 ` [Qemu-devel] [PULL 14/14] configure: improve usbfs check Laurent Vivier
2019-02-14 18:32 ` [Qemu-devel] [PULL 00/14] Trivial branch patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214104717.3543-10-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kamil@netbsd.org \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=libvir-list@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).