From: Alex Williamson <alex.williamson@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [Qemu-devel] [PATCH qemu] pci: Move NVIDIA vendor id to the rest of ids
Date: Thu, 14 Feb 2019 16:37:55 -0700 [thread overview]
Message-ID: <20190214163755.5e76ae62@w520.home> (raw)
In-Reply-To: <20190214051440.59167-1-aik@ozlabs.ru>
On Thu, 14 Feb 2019 16:14:40 +1100
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> sPAPR code will use it too so move it from VFIO to the common code.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>
> Previous version was RFC, this is is not.
I assume as a stand-alone patch this should go through the PCI branch,
cc'ing maintainers.
Acked-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> include/hw/pci/pci_ids.h | 2 ++
> hw/vfio/pci-quirks.c | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
> index eeb3301..0abe27a 100644
> --- a/include/hw/pci/pci_ids.h
> +++ b/include/hw/pci/pci_ids.h
> @@ -271,4 +271,6 @@
>
> #define PCI_VENDOR_ID_SYNOPSYS 0x16C3
>
> +#define PCI_VENDOR_ID_NVIDIA 0x10de
> +
> #endif
> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> index eae31c7..40a1200 100644
> --- a/hw/vfio/pci-quirks.c
> +++ b/hw/vfio/pci-quirks.c
> @@ -526,8 +526,6 @@ static void vfio_probe_ati_bar2_quirk(VFIOPCIDevice *vdev, int nr)
> * note it for future reference.
> */
>
> -#define PCI_VENDOR_ID_NVIDIA 0x10de
> -
> /*
> * Nvidia has several different methods to get to config space, the
> * nouveu project has several of these documented here:
prev parent reply other threads:[~2019-02-14 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 5:14 [Qemu-devel] [PATCH qemu] pci: Move NVIDIA vendor id to the rest of ids Alexey Kardashevskiy
2019-02-14 23:37 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214163755.5e76ae62@w520.home \
--to=alex.williamson@redhat.com \
--cc=aik@ozlabs.ru \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).