qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v3 0/3] target/arm: Implement ARMv8.3-JSConv
Date: Thu, 14 Feb 2019 13:21:41 -0800	[thread overview]
Message-ID: <20190214212144.12784-1-richard.henderson@linaro.org> (raw)

Based-on: something akin to target-arm.next, with the gvec changes,
but without the v2 2/3 "Restructure disas_fp_int_conv".

The full tree is at

  https://github.com/rth7680/qemu.git tgt-arm-jscvt

Patch 1 splits out vfp_helper.c, which I wrote for something else.
But while rebasing it occured to me that helper_vjcvt is better placed
in vfp_helper.c than op_helper.c, so why not include it here and now.

Patch 2 corresponds to the v2 patch 2, but totally rewritten.  What
I missed the first time around is that register Sn is encoded differenly
than Dn, so merely setting dp = 0 doesn't help because we've already
decoded the register number incorrectly.  Therefore, replace some really
ugly if conditions and set some variables as appropriate.

Patch 3 is adjusted to match the change in decode from patch 2, and
putting the aa32 flags in the right place.

And now, finally, tested aa32 vs risu.


r~


Richard Henderson (3):
  target/arm: Split out vfp_helper.c
  target/arm: Rearrange decode of Floating-point data-processing (2
    regs)
  target/arm: Implement ARMv8.3-JSConv

 target/arm/cpu.h           |   10 +
 target/arm/helper.h        |    3 +
 target/arm/cpu.c           |    1 +
 target/arm/cpu64.c         |    2 +
 target/arm/helper.c        | 1062 --------------------------------
 target/arm/translate-a64.c |   26 +
 target/arm/translate.c     |  237 ++++----
 target/arm/vfp_helper.c    | 1176 ++++++++++++++++++++++++++++++++++++
 target/arm/Makefile.objs   |    2 +-
 9 files changed, 1340 insertions(+), 1179 deletions(-)
 create mode 100644 target/arm/vfp_helper.c

-- 
2.17.2

             reply	other threads:[~2019-02-14 21:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 21:21 Richard Henderson [this message]
2019-02-14 21:21 ` [Qemu-devel] [PATCH v3 1/3] target/arm: Split out vfp_helper.c Richard Henderson
2019-02-14 21:21 ` [Qemu-devel] [PATCH v3 2/3] target/arm: Rearrange decode of Floating-point data-processing (2 regs) Richard Henderson
2019-02-14 21:21 ` [Qemu-devel] [PATCH v3 3/3] target/arm: Implement ARMv8.3-JSConv Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214212144.12784-1-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).