From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>,
David Gibson <david@gibson.dropbear.id.au>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Collin Walling <walling@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Greg Kurz <groug@kaod.org>, Igor Mammedov <imammedo@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v2 4/6] tests/device-plug: Add CCW unplug test for s390x
Date: Fri, 15 Feb 2019 14:30:03 +0100 [thread overview]
Message-ID: <20190215133005.15955-5-david@redhat.com> (raw)
In-Reply-To: <20190215133005.15955-1-david@redhat.com>
As CCW unplugs are surprise removals without asking the guest first,
we can test this without any guest interaction.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
tests/device-plug-test.c | 41 +++++++++++++++++++++++++++++++++++-----
1 file changed, 36 insertions(+), 5 deletions(-)
diff --git a/tests/device-plug-test.c b/tests/device-plug-test.c
index 066433ebf5..6f7255552a 100644
--- a/tests/device-plug-test.c
+++ b/tests/device-plug-test.c
@@ -15,17 +15,26 @@
#include "qapi/qmp/qdict.h"
#include "qapi/qmp/qstring.h"
-static void device_del_request(QTestState *qtest, const char *id)
+static void device_del_start(QTestState *qtest, const char *id)
{
- QDict *resp;
+ qtest_qmp_send(qtest,
+ "{'execute': 'device_del', 'arguments': { 'id': %s } }", id);
+}
+
+static void device_del_finish(QTestState *qtest)
+{
+ QDict *resp = qtest_qmp_receive(qtest);
- resp = qtest_qmp(qtest,
- "{'execute': 'device_del', 'arguments': { 'id': %s } }",
- id);
g_assert(qdict_haskey(resp, "return"));
qobject_unref(resp);
}
+static void device_del_request(QTestState *qtest, const char *id)
+{
+ device_del_start(qtest, id);
+ device_del_finish(qtest);
+}
+
static void system_reset(QTestState *qtest)
{
QDict *resp;
@@ -77,8 +86,25 @@ static void test_pci_unplug_request(void)
qtest_quit(qtest);
}
+static void test_ccw_unplug(void)
+{
+ QTestState *qtest = qtest_initf("-device virtio-balloon-ccw,id=dev0");
+
+ /*
+ * The DEVICE_DELETED events will be sent before the command
+ * completes.
+ */
+ device_del_start(qtest, "dev0");
+ wait_device_deleted_event(qtest, "dev0");
+ device_del_finish(qtest);
+
+ qtest_quit(qtest);
+}
+
int main(int argc, char **argv)
{
+ const char *arch = qtest_get_arch();
+
g_test_init(&argc, &argv, NULL);
/*
@@ -89,5 +115,10 @@ int main(int argc, char **argv)
qtest_add_func("/device-plug/pci_unplug_request",
test_pci_unplug_request);
+ if (!strcmp(arch, "s390x")) {
+ qtest_add_func("/device-plug/ccw_unplug",
+ test_ccw_unplug);
+ }
+
return g_test_run();
}
--
2.17.2
next prev parent reply other threads:[~2019-02-15 13:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 13:29 [Qemu-devel] [PATCH v2 0/6] tests: Add device unplug tests David Hildenbrand
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 1/6] cpus: Properly release the iothread lock when killing a dummy VCPU David Hildenbrand
2019-02-15 14:53 ` Greg Kurz
2019-02-15 15:14 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-02-17 23:58 ` [Qemu-devel] " David Gibson
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 2/6] spapr: support memory unplug for qtest David Hildenbrand
2019-02-15 14:30 ` Greg Kurz
2019-02-17 23:59 ` David Gibson
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 3/6] tests/device-plug: Add a simple PCI unplug request test David Hildenbrand
2019-02-15 15:20 ` Greg Kurz
2019-02-15 15:21 ` Thomas Huth
2019-02-18 8:42 ` David Hildenbrand
2019-02-15 18:37 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-02-18 0:58 ` [Qemu-devel] " David Gibson
2019-02-15 13:30 ` David Hildenbrand [this message]
2019-02-15 15:29 ` [Qemu-devel] [PATCH v2 4/6] tests/device-plug: Add CCW unplug test for s390x Thomas Huth
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 5/6] tests/device-plug: Add CPU core unplug request test for spapr David Hildenbrand
2019-02-15 15:35 ` Thomas Huth
2019-02-18 8:46 ` David Hildenbrand
2019-02-15 16:03 ` Greg Kurz
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 6/6] tests/device-plug: Add memory " David Hildenbrand
2019-02-15 15:56 ` Thomas Huth
2019-02-18 3:23 ` David Gibson
2019-02-15 15:58 ` Thomas Huth
2019-02-18 8:50 ` David Hildenbrand
2019-02-15 16:03 ` Greg Kurz
2019-02-15 21:27 ` [Qemu-devel] [PATCH v2 0/6] tests: Add device unplug tests Michael S. Tsirkin
2019-02-15 22:09 ` David Hildenbrand
2019-02-18 3:24 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215133005.15955-5-david@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).