From: Igor Mammedov <imammedo@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, ehabkost@redhat.com,
mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, jan.kiszka@web.de, atar4qemu@gmail.com
Subject: Re: [Qemu-devel] [RFC] memory: use memory_region_init_ram() instead of memory_region_allocate_system_memory()
Date: Fri, 15 Feb 2019 16:42:09 +0100 [thread overview]
Message-ID: <20190215164209.54a6f747@Igors-MacBook-Pro.local> (raw)
In-Reply-To: <2d99aca8-5ed0-bea3-4a4f-7b2a8e89b049@redhat.com>
On Fri, 15 Feb 2019 15:48:43 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 15/02/19 12:33, Igor Mammedov wrote:
> > On Thu, 14 Feb 2019 19:11:27 +0100
> > Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> >> On 14/02/19 15:07, Igor Mammedov wrote:
> >>> Also some boards (ab)use memory_region_allocate_system_memory(), calling it several
> >>> times to allocate various fixed sized chunks of RAM and ROMs, which is problematic
> >>> to map to a single initial RAM Machine::memdev backend and is currently broken if
> >>> -mem-path points to a not hugepage pool.
> >>
> >> This is certainly a good idea. However, I'm not sure why you would need
> >> a memdev property on the Machine instead of just allowing 1 -numa node,
> >> which is what really is.
> >
> > using '-numa node' would be confusing to user when he/she is not interested in numa usecase
> > it also would enable numa fdt/acpi parts generated automatically (fixable but then again
> > it adds more to confusion) and in the end there are boards that do not support numa at all
> > (s390x).
>
> Fair enough.
>
> What about -m, too? Then you'd specify a memdev instead of the initial
> memory size.
that somewhat what I've planned,
make -m X translate into -object memory-backend-ram,id=magically-get-what-board-uses-now,size=X -machine memdev=thatid
one more reason for memdev vs device is that -numa now uses memdevs and so far it
doesn't look that non-numa initial RAM would get immediate benefits from using -device
on most boards (well, I couldn't come up with any modulo backend/frontend consistent usage)
>
> Paolo
>
next prev parent reply other threads:[~2019-02-15 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 14:07 [Qemu-devel] [RFC] memory: use memory_region_init_ram() instead of memory_region_allocate_system_memory() Igor Mammedov
2019-02-14 18:11 ` Paolo Bonzini
2019-02-15 11:33 ` Igor Mammedov
2019-02-15 14:48 ` Paolo Bonzini
2019-02-15 15:42 ` Igor Mammedov [this message]
2019-02-15 18:18 ` Paolo Bonzini
2019-02-18 9:31 ` Igor Mammedov
2019-02-14 18:30 ` Peter Maydell
2019-02-15 11:45 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215164209.54a6f747@Igors-MacBook-Pro.local \
--to=imammedo@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@web.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).